Bug 174837

Summary: Make run-javascriptcore-test run testair, testb3, and testmasm.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: Tools / TestsAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, buildbot, dean_johnson, fpizlo, jfbastien, jlewis3, keith_miller, lforschler, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174645    
Attachments:
Description Flags
proposed patch.
saam: review+, buildbot: commit-queue-
Archive of layout-test-results from ews126 for ios-simulator-wk2 none

Mark Lam
Reported 2017-07-25 14:57:08 PDT
Coming soon.
Attachments
proposed patch. (8.35 KB, patch)
2017-07-26 12:52 PDT, Mark Lam 		saam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (13.41 MB, application/zip)
2017-07-26 14:19 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-07-25 14:58:30 PDT
<rdar://problem/33522927>
Mark Lam
Comment 2 2017-07-26 12:52:45 PDT
Created attachment 316465 [details] proposed patch.
Build Bot
Comment 3 2017-07-26 14:19:45 PDT
Comment on attachment 316465 [details] proposed patch. Attachment 316465 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4192166 New failing tests: imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
Build Bot
Comment 4 2017-07-26 14:19:47 PDT
Created attachment 316480 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Mark Lam
Comment 5 2017-07-26 14:28:13 PDT
(In reply to Build Bot from comment #4) > Created attachment 316480 [details] > Archive of layout-test-results from ews126 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5 This test failure has to be bogus because I didn't change the layout tests nor any source code (as opposed to the run-jsvaascriptcore-tests script).
Saam Barati
Comment 6 2017-07-26 14:56:59 PDT
Comment on attachment 316465 [details] proposed patch. r=me
Filip Pizlo
Comment 7 2017-07-26 14:57:38 PDT
Comment on attachment 316465 [details] proposed patch. r=me too
Mark Lam
Comment 8 2017-07-26 15:16:10 PDT
Thanks for the review. Landed in r219965: <http://trac.webkit.org/r219965>.
Alexey Proskuryakov
Comment 9 2017-07-27 13:37:35 PDT
Could you please update the dashboard too? Running the tests on bots is of little use if we can't see the results. Also, I'm not sure how this impacts EWS, unexpected subtests might break it.
Mark Lam
Comment 10 2017-07-27 13:42:30 PDT
(In reply to Alexey Proskuryakov from comment #9) > Could you please update the dashboard too? Running the tests on bots is of > little use if we can't see the results. > > Also, I'm not sure how this impacts EWS, unexpected subtests might break it. We can see the results to the extent that we can see failures in testapi today ... which results in a crash, and the jsc stress tests, etc not running. The same goes for these new tests: if there's a failure, it crashes.
Aakash Jain
Comment 11 2017-07-28 13:20:26 PDT
> Could you please update the dashboard too? Running the tests on bots is of > little use if we can't see the results. Dashboard already shows JSC tests (Debug and Release). Since this patch just adds more tests in the same run-javascriptcore-tests script, and dashboard already parses the output of run-javascriptcore-tests, it seems that dashboard should just work. Please let me know if it doesn't.
Alexey Proskuryakov
Comment 12 2017-07-28 14:49:26 PDT
How exactly does it look on the dashboard when (for example) testair fails?
Note You need to log in before you can comment on or make changes to this bug.