| Summary: | [GStreamer] Don't use GraphicsContext3D in VideoTextureCoperGStreamer | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | WebKitGTK | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bugs-noreply, buildbot, cgarcia, magomez | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 174860 | ||||||||
| Attachments: |
|
||||||||
|
Description
Zan Dobersek
2017-07-24 00:10:04 PDT
Created attachment 316271 [details]
WIP
Attachment 316271 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 317559 [details]
Patch
Attachment 317559 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 317559 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317559&action=review > Source/WebCore/platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:30 > +// FIXME: Remove avter TextureMapperShaderProgram drops GraphicsContext3D usage. after? > Source/WebCore/platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:42 > + // FIXME: Remove avter TextureMapperShaderProgram drops GraphicsContext3D usage. Ditto. Committed r220402: <http://trac.webkit.org/changeset/220402> |