Summary: | Refactor MASM probe CPUState to use arrays for register storage. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, fpizlo, jfbastien, keith_miller, msaboff, saam, ysuzuki | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 174645 | ||||||||||
Attachments: |
|
Description
Mark Lam
2017-07-20 15:53:12 PDT
Created attachment 316041 [details]
work in progress.
Attachment 316041 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/assembler/ARM64Assembler.h:218: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/assembler/ARM64Assembler.h:227: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/assembler/ARM64Assembler.h:236: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 3 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 316041 [details] work in progress. Attachment 316041 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4158923 New failing tests: imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html Created attachment 316067 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Created attachment 316107 [details]
proposed patch.
Comment on attachment 316107 [details]
proposed patch.
r=me.
Comment on attachment 316107 [details]
proposed patch.
Thanks for the review.
Comment on attachment 316107 [details] proposed patch. Clearing flags on attachment: 316107 Committed r219740: <http://trac.webkit.org/changeset/219740> All reviewed patches have been landed. Closing bug. |