Bug 174694

Summary: Refactor MASM probe CPUState to use arrays for register storage.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, jfbastien, keith_miller, msaboff, saam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174645    
Attachments:
Description Flags
work in progress.
buildbot: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
proposed patch. none

Mark Lam
Reported 2017-07-20 15:53:12 PDT
This patch aims to: 1. Remove the need for macros for defining the list of CPU registers. 2. Make the assembler the authority on register names. 3. make the assembler the authority on the number of registers of each type.
Attachments
work in progress. (99.89 KB, patch)
2017-07-20 16:40 PDT, Mark Lam 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (9.98 MB, application/zip)
2017-07-20 21:14 PDT, Build Bot 		no flags
Details
proposed patch. (105.35 KB, patch)
2017-07-21 12:01 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2017-07-20 16:40:49 PDT
Created attachment 316041 [details] work in progress.
Build Bot
Comment 2 2017-07-20 16:43:20 PDT
Attachment 316041 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/ARM64Assembler.h:218: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/assembler/ARM64Assembler.h:227: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/assembler/ARM64Assembler.h:236: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2017-07-20 21:14:06 PDT
Comment on attachment 316041 [details] work in progress. Attachment 316041 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4158923 New failing tests: imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
Build Bot
Comment 4 2017-07-20 21:14:08 PDT
Created attachment 316067 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Mark Lam
Comment 5 2017-07-21 12:01:39 PDT
Created attachment 316107 [details] proposed patch.
Keith Miller
Comment 6 2017-07-21 12:16:57 PDT
Comment on attachment 316107 [details] proposed patch. r=me.
Mark Lam
Comment 7 2017-07-21 13:17:19 PDT
Comment on attachment 316107 [details] proposed patch. Thanks for the review.
WebKit Commit Bot
Comment 8 2017-07-21 13:44:37 PDT
Comment on attachment 316107 [details] proposed patch. Clearing flags on attachment: 316107 Committed r219740: <http://trac.webkit.org/changeset/219740>
WebKit Commit Bot
Comment 9 2017-07-21 13:44:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.