Bug 174620

Summary: [GTK] The binding code of Media Source Extension of AudioTrack, VideoTrack and TextTrack is not generated
Product: WebKit Reporter: Nael Ouedraogo <nael.ouedp>
Component: MediaAssignee: Nael Ouedraogo <nael.ouedp>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eocanha, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=179372
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Nael Ouedraogo
Reported 2017-07-18 02:43:32 PDT
The binding code of Media Source Extension of AudioTrack, VideoTrack and TextTrack is not generated.
Attachments
Patch (13.79 KB, patch)
2017-07-18 03:22 PDT, Nael Ouedraogo 		no flags
DetailsFormatted DiffDiff
Patch (13.82 KB, patch)
2017-09-18 06:18 PDT, Nael Ouedraogo 		no flags
DetailsFormatted DiffDiff
Patch (13.85 KB, patch)
2017-09-19 01:08 PDT, Nael Ouedraogo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nael Ouedraogo
Comment 1 2017-07-18 03:22:11 PDT
Created attachment 315785 [details] Patch
Enrique Ocaña
Comment 2 2017-09-05 02:39:54 PDT
This patch looks good to me, but I can't r+ it (I'm not a reviewer).
Michael Catanzaro
Comment 3 2017-09-05 08:21:32 PDT
Comment on attachment 315785 [details] Patch I'll rubber-stamp this since Enrique is our MSE expert. Sorry for the delay.
Nael Ouedraogo
Comment 4 2017-09-18 06:18:12 PDT
Created attachment 321088 [details] Patch
Nael Ouedraogo
Comment 5 2017-09-18 06:19:07 PDT
Thanks for the reviews.
Michael Catanzaro
Comment 6 2017-09-18 06:34:55 PDT
Do you want me to give cq+ on this?
Nael Ouedraogo
Comment 7 2017-09-18 06:46:33 PDT
I was waiting for EWS to finish testing gtk and wpe ports. Thanks !
WebKit Commit Bot
Comment 8 2017-09-18 07:11:21 PDT
Comment on attachment 321088 [details] Patch Rejecting attachment 321088 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 321088, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ab9e1cc9016cf597ac9a1ca756c9f23dc5 86a8d7212f99ef652aa59bf346f93989ecd2afbd M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Total errors found: 0 in 1 files Full output: http://webkit-queues.webkit.org/results/4582961
Nael Ouedraogo
Comment 9 2017-09-19 01:08:11 PDT
Created attachment 321188 [details] Patch
WebKit Commit Bot
Comment 10 2017-09-19 02:00:19 PDT
Comment on attachment 321188 [details] Patch Clearing flags on attachment: 321188 Committed r222205: <http://trac.webkit.org/changeset/222205>
WebKit Commit Bot
Comment 11 2017-09-19 02:00:21 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2017-09-27 12:50:25 PDT
<rdar://problem/34694118>
Note You need to log in before you can comment on or make changes to this bug.