Bug 174557

Summary:

[CMake] Create targets before WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS is called

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WebKit Misc.

Assignee:

Konstantin Tokarev <annulen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, annulen, buildbot, commit-queue, Hironori.Fujii, mcatanzaro

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Patch	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none

Description Michael Catanzaro 2017-07-15 20:40:16 PDT

In bug #174545, Konstantin points out:

"FWIW, raising requirement to 3.1 would allow us to use target_sources command, that can enable us to make target-specific setup in PlatformXXX.cmake files (now all such code has to be in shared CMakeLists.txt files)"

We should do it.

Comment 1 Michael Catanzaro 2017-07-15 20:42:55 PDT

I'm not going to work on this one now, but I figured I might as well file the bug now, so we don't forget to do it. It will be a nice cleanup.

We can split more backend files to secondary cmake files at the same time, to avoid e.g. having a list of the same files to compile in both PlatformGTK.cmake and PlatformWPE.cmake.

Comment 2 Konstantin Tokarev 2017-07-16 12:28:00 PDT

Created attachment 315617 [details]
Patch

Comment 3 Build Bot 2017-07-16 13:47:04 PDT

Comment on attachment 315617 [details]
Patch

Attachment 315617 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4131971

New failing tests:
security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html

Comment 4 Build Bot 2017-07-16 13:47:06 PDT

Created attachment 315622 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 5 Konstantin Tokarev 2017-07-16 13:47:14 PDT

Created attachment 315623 [details]
Patch

Comment 6 Build Bot 2017-07-16 16:14:51 PDT

Comment on attachment 315623 [details]
Patch

Attachment 315623 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4132526

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
http/tests/cache/disk-cache/speculative-validation/cacheable-redirect.html

Comment 7 Build Bot 2017-07-16 16:14:52 PDT

Created attachment 315631 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

Comment 8 Michael Catanzaro 2017-07-16 20:03:50 PDT

Comment on attachment 315623 [details]
Patch

Is this just step one? What is the advantage of doing this?

Comment 9 Konstantin Tokarev 2017-07-17 00:59:53 PDT

Advantage is that commands that operate on targets can now be used in PlatformXXX.cmake files

Comment 10 WebKit Commit Bot 2017-07-17 08:16:57 PDT

Comment on attachment 315623 [details]
Patch

Clearing flags on attachment: 315623

Committed r219560: <http://trac.webkit.org/changeset/219560>

Comment 11 WebKit Commit Bot 2017-07-17 08:16:59 PDT

All reviewed patches have been landed.  Closing bug.