Bug 174343

Summary: [PAL] Move SoftLink into PAL
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, buildbot, don.olmstead, mmaxfield, yoshiaki.jitsukawa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 175542    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
WIP Patch none

Yoshiaki Jitsukawa
Reported 2017-07-10 19:48:17 PDT
I'm thinking of moving the "Clock" to PAL https://bugs.webkit.org/show_bug.cgi?id=174342 but it has a dependency onto CoreMediaSoftLink. CoreMediaSoftLink and other SoftLink sources need to be moved to PAL in advance.
Attachments
WIP Patch (85.36 KB, patch)
2017-09-06 15:39 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
WIP Patch (90.42 KB, patch)
2017-09-06 15:45 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2017-07-10 19:59:43 PDT
I'm wondering where CoreMediaSoftLink.* should go under "PAL/pal" as various platform sources depend on it and it doesn't seem to belong to a single component (such as File or Clock or whatever)
Myles C. Maxfield
Comment 2 2017-07-11 11:09:44 PDT
(In reply to Yoshiaki Jitsukawa from comment #1) > I'm wondering where CoreMediaSoftLink.* should go under "PAL/pal" as various > platform sources depend on it and it doesn't seem to belong to a single > component (such as File or Clock or whatever) It should go under PAL/pal.
Yoshiaki Jitsukawa
Comment 3 2017-07-12 23:43:42 PDT
For WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h for example, which is appropriate? PAL/pal/cf/AVFoundationCFSoftLinking.h PAL/pal/platform/cf/AVFoundationCFSoftLinking.h PAL/pal/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h or somewhere else?
Yoshiaki Jitsukawa
Comment 4 2017-09-06 15:39:58 PDT
Created attachment 320068 [details] WIP Patch
Build Bot
Comment 5 2017-09-06 15:41:42 PDT
Attachment 320068 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/cocoa/CoreVideoSoftLink.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/PAL/pal/cocoa/CoreVideoSoftLink.cpp:43: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/PAL/pal/PALPrefix.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/PAL/pal/cf/MediaAccessibilitySoftLink.h:25: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/PAL/pal/CMakeLists.txt:30: One space between command "endif" and its parentheses, should be "endif (" [whitespace/parentheses] [5] Total errors found: 5 in 69 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yoshiaki Jitsukawa
Comment 6 2017-09-06 15:45:28 PDT
Created attachment 320069 [details] WIP Patch
Yoshiaki Jitsukawa
Comment 7 2017-09-07 18:44:26 PDT
Some SoftLink files seem to depend on the WebCorePrefix.h. It'll need PALPrefix.h to move these files into PAL.
Yoshiaki Jitsukawa
Comment 8 2017-09-25 18:34:35 PDT
CoreMediaSoftLink has already been introduced into PAL and we should add some other on demand. Closing.
Note You need to log in before you can comment on or make changes to this bug.