Bug 173704

Summary: [iOS] Do not flatten frames when async frame scrolling is enabled
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: FramesAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: fred.wang, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 171914    
Bug Blocks: 149264, 183081    
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Frédéric Wang (:fredw)
Reported 2017-06-22 02:30:50 PDT
This will allow developers to test async frame scrolling without to explicitly disable frame flattening.
Attachments
Patch (12.38 KB, patch)
2017-06-22 02:45 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (12.43 KB, patch)
2017-09-27 02:23 PDT, Frédéric Wang (:fredw) 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2017-06-22 02:45:56 PDT
Created attachment 313604 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2017-09-27 01:48:39 PDT
The patch is bit-rotten. It seems that the new iOS simulator exposes experimental features which make this more interesting now. Maybe we can just completely disable frame flattening instead of just enabling the heuristics?
Frédéric Wang (:fredw)
Comment 3 2017-09-27 02:23:19 PDT
Created attachment 321946 [details] Patch
Simon Fraser (smfr)
Comment 4 2017-10-10 13:04:52 PDT
Comment on attachment 321946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321946&action=review > Source/WebCore/page/Settings.cpp:427 > +FrameFlattening Settings::actualFrameFlattening() This is a very confusing name. Maybe "effectiveFrameFlattening" would be slightly less confusing?
Frédéric Wang (:fredw)
Comment 5 2017-10-11 00:49:33 PDT
(In reply to Simon Fraser (smfr) from comment #4) > This is a very confusing name. Maybe "effectiveFrameFlattening" would be > slightly less confusing? OK, I'll change it.
Frédéric Wang (:fredw)
Comment 6 2017-10-11 00:54:44 PDT
Committed r223169: <http://trac.webkit.org/changeset/223169>
Radar WebKit Bug Importer
Comment 7 2017-10-11 00:55:09 PDT
<rdar://problem/34928725>
Note You need to log in before you can comment on or make changes to this bug.