Bug 173405

Summary: [iOS] Always include frames in the scrolling tree when fast frame scrolling is enabled
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: FramesAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, fred.wang, simon.fraser
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 133665, 173359    
Bug Blocks: 149264    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
alternative Patch
none
Patch
none
Patch (173359+173405)
none
Patch simon.fraser: review+

Description Frédéric Wang (:fredw) 2017-06-15 01:39:47 PDT
Same as bug 172851, but for iOS and for frame flattening.
Comment 1 Frédéric Wang (:fredw) 2017-06-15 02:21:59 PDT
Created attachment 312965 [details]
Patch
Comment 2 Build Bot 2017-06-15 03:28:08 PDT
Comment on attachment 312965 [details]
Patch

Attachment 312965 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3934570

New failing tests:
imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin.html
fast/frames/frame-scrolling-attribute.html
imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-cross-origin.html
fast/text-autosizing/ios/contenteditable.html
fast/frames/frameset-style-recalc.html
compositing/iframes/iframe-copy-on-scroll.html
fast/frames/take-focus-from-iframe.html
tables/mozilla/bugs/bug131020.html
compositing/iframes/iframe-in-composited-layer.html
fast/scrolling/scrolling-tree-includes-frame.html
fast/overflow/scrollRevealButton.html
fast/frames/iframe-scrolling-attribute.html
compositing/iframes/overlapped-iframe-iframe.html
fast/regions/repaint/line-flow-with-floats-in-regions.html
fast/forms/basic-textareas.html
Comment 3 Build Bot 2017-06-15 03:28:09 PDT
Created attachment 312967 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 4 Frédéric Wang (:fredw) 2017-06-15 03:44:03 PDT
Created attachment 312968 [details]
Patch
Comment 5 Build Bot 2017-06-15 05:11:10 PDT
Comment on attachment 312968 [details]
Patch

Attachment 312968 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3934943

New failing tests:
imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin.html
fast/frames/frameset-style-recalc.html
imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-cross-origin.html
fast/text-autosizing/ios/contenteditable.html
fast/frames/frame-scrolling-attribute.html
compositing/iframes/iframe-copy-on-scroll.html
fast/frames/take-focus-from-iframe.html
tables/mozilla/bugs/bug131020.html
compositing/iframes/iframe-in-composited-layer.html
fast/overflow/scrollRevealButton.html
fast/frames/iframe-scrolling-attribute.html
compositing/iframes/overlapped-iframe-iframe.html
fast/regions/repaint/line-flow-with-floats-in-regions.html
fast/forms/basic-textareas.html
Comment 6 Build Bot 2017-06-15 05:11:11 PDT
Created attachment 312970 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 7 Frédéric Wang (:fredw) 2017-06-15 06:35:19 PDT
Created attachment 312976 [details]
alternative Patch
Comment 8 Frédéric Wang (:fredw) 2017-06-15 07:53:42 PDT
Created attachment 312980 [details]
Patch
Comment 9 Frédéric Wang (:fredw) 2017-06-15 23:01:27 PDT
As I see, some frames are already be included in the scrolling tree after bug 133665. So I guess I should come back to the initial idea of making this for all frames when frame flattening is disabled.
Comment 10 Frédéric Wang (:fredw) 2017-06-15 23:02:16 PDT
Comment on attachment 312980 [details]
Patch

Cancelling review per Simon's comments on IRC.
Comment 11 Frédéric Wang (:fredw) 2017-06-19 06:19:35 PDT
Created attachment 313286 [details]
Patch (173359+173405)
Comment 12 Frédéric Wang (:fredw) 2017-06-19 07:21:21 PDT
Created attachment 313293 [details]
Patch

This patch applies on top of bug 173359.
Comment 13 Frédéric Wang (:fredw) 2017-06-19 23:06:27 PDT
Committed r218535: <http://trac.webkit.org/changeset/218535>