Bug 172851 - [Mac] Use compositing for frames when ScrollingTreeIncludesFrames=true
Summary: [Mac] Use compositing for frames when ScrollingTreeIncludesFrames=true
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on:
Blocks: 171667 172825
  Show dependency treegraph
 
Reported: 2017-06-02 01:59 PDT by Frédéric Wang (:fredw)
Modified: 2017-06-02 11:43 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.37 KB, patch)
2017-06-02 02:18 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (998.26 KB, application/zip)
2017-06-02 03:17 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.74 MB, application/zip)
2017-06-02 03:39 PDT, Build Bot
no flags Details
Patch (8.72 KB, patch)
2017-06-02 03:48 PDT, Frédéric Wang (:fredw)
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2017-06-02 01:59:57 PDT
This piece is extracted from bug 171667, where we will need a separate layer for the scrollable frames. For now, we will only do that when ScrollingTreeIncludesFrames=true, so that we do not change the default behavior.
Comment 1 Frédéric Wang (:fredw) 2017-06-02 02:18:12 PDT
Created attachment 311809 [details]
Patch
Comment 2 Build Bot 2017-06-02 03:17:11 PDT
Comment on attachment 311809 [details]
Patch

Attachment 311809 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3858870

New failing tests:
compositing/iframes/compositing-for-scrollable-iframe.html
Comment 3 Build Bot 2017-06-02 03:17:12 PDT
Created attachment 311813 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-06-02 03:38:59 PDT
Comment on attachment 311809 [details]
Patch

Attachment 311809 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3858895

New failing tests:
compositing/iframes/compositing-for-scrollable-iframe.html
Comment 5 Build Bot 2017-06-02 03:39:00 PDT
Created attachment 311816 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Frédéric Wang (:fredw) 2017-06-02 03:48:12 PDT
Created attachment 311817 [details]
Patch
Comment 7 Simon Fraser (smfr) 2017-06-02 10:58:49 PDT
Comment on attachment 311817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311817&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h:229
> +            ScrollableInnerFrameTrigger |

Maybe ScrollableNonMainFrameTrigger?

I don't actually know if anyone uses these triggers any more, now that Blink is out of the repo.
Comment 8 Frédéric Wang (:fredw) 2017-06-02 11:42:14 PDT
Committed r217726: <http://trac.webkit.org/changeset/217726>
Comment 9 Frédéric Wang (:fredw) 2017-06-02 11:43:45 PDT
(In reply to Simon Fraser (smfr) from comment #7)
> I don't actually know if anyone uses these triggers any more, now that Blink
> is out of the repo.

Yes, this is actually only used in RenderLayerCompositor::requiresCompositingForScrollableFrame ; I renamed the flag as you suggest.