Bug 133665 - Work towards having frames in the scrolling tree
Summary: Work towards having frames in the scrolling tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 133694 149264 173405
  Show dependency tree / graph
 
Reported: 2014-06-09 16:43 PDT by Simon Fraser (smfr)
Modified: 2017-06-15 23:01 PDT (History)
13 users (show)

See Also:

Attachments
Patch (59.39 KB, patch)
2014-06-09 17:10 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-06-09 16:43:54 PDT 
Work towards having frames in the scrolling tree
Comment 1 Simon Fraser (smfr) 2014-06-09 17:10:54 PDT 
Created attachment 232750 [details]
Patch
Comment 2 Tim Horton 2014-06-09 17:20:39 PDT 
Comment on attachment 232750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232750&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3611
> +    RenderElement* frameRenderer = ownerElement ? ownerElement->renderer() : 0;

nullptr

> Source/WebCore/rendering/RenderView.cpp:842
> +    // FIXME: view() is just *this here.

why the fixme instead of fixing?
Comment 3 Simon Fraser (smfr) 2014-06-09 17:39:27 PDT 
https://trac.webkit.org/r169733