Bug 173277 – [iOS] Cmd-C doesn't copy text from WKWebView

• Component: New Bugs
• Status: RESOLVED FIXED

[Tim Horton]

[iOS] Cmd-C doesn't copy text from WKWebView

[Tim Horton]

Created attachment 312699 [details]
Patch

[Tim Horton]

rdar://problem/32396742

Comment on attachment 312699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312699&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h:133
> +- (void)_addShortcut:(id)sender;
> +- (void)_arrowKey:(id)sender;
> +- (void)_define:(id)sender;
> +- (void)_lookup:(id)sender;
> +- (void)_reanalyze:(id)sender;
> +- (void)_share:(id)sender;
> +- (void)_showTextStyleOptions:(id)sender;
> +- (void)_promptForReplace:(id)sender;
> +- (void)_transliterateChinese:(id)sender;
> +- (void)replace:(id)sender;

Are these necessary?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:343
> +

?

[Tim Horton]

Comment on attachment 312699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312699&action=review

>> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h:133
>> +- (void)replace:(id)sender;
> 
> Are these necessary?

I think so? I moved these here from WKContentViewInteraction. They're called from another file (WKContentViewInteraction.mm), and aren't in any header that we can always see.

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:343
>> +
> 
> ?

Not a clue.

[Tim Horton]

https://trac.webkit.org/changeset/218144/webkit

[Matt Lewis]

I believe this revision https://trac.webkit.org/changeset/218144/webkit caused an api failure on iOS.

[Tim Horton]

The API test doesn’t work? Works for me in the sim. I will investigate tomorrow.

[Tim Horton]

Odd, running the test alone is fine, but running it with all the others causes it to fail.

[Tim Horton]

That seems to not always be true, sometimes it times out alone too.

[Tim Horton]

https://bugs.webkit.org/show_bug.cgi?id=173374 will fix the test

(In reply to Tim Horton from comment #5)
> https://trac.webkit.org/changeset/218144/webkit

This caused bug 176077.