Bug 173130

Summary: Use WTF::getCurrentProcessID() instead of getpid().
Product: WebKit Reporter: Daewoong Jang <daewoong.jang>
Component: WebKit2Assignee: Daewoong Jang <daewoong.jang>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, commit-queue, darin, thorton, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Daewoong Jang
Reported 2017-06-08 22:54:35 PDT
Use WTF::getCurrentProcessID() instead of getpid().
Attachments
patch (1.46 KB, patch)
2017-06-08 22:56 PDT, Daewoong Jang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daewoong Jang
Comment 1 2017-06-08 22:56:15 PDT
Created attachment 312387 [details] patch
WebKit Commit Bot
Comment 2 2017-06-09 03:39:59 PDT
Comment on attachment 312387 [details] patch Clearing flags on attachment: 312387 Committed r217975: <http://trac.webkit.org/changeset/217975>
WebKit Commit Bot
Comment 3 2017-06-09 03:40:01 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2017-06-12 18:14:40 PDT
Out of curiosity, what is the benefit of one over another here?
Daewoong Jang
Comment 5 2017-06-12 18:36:54 PDT
(In reply to Alexey Proskuryakov from comment #4) > Out of curiosity, what is the benefit of one over another here? Now it can be compiled for more platforms(e.g. Windows).
Alexey Proskuryakov
Comment 6 2017-06-12 18:52:44 PDT
This is WebKit2 code, and WebKit2 does not support Windows. That would be large undertaking, which should be discussed on webkit-dev before starting.
Daewoong Jang
Comment 7 2017-06-12 18:59:43 PDT
(In reply to Alexey Proskuryakov from comment #6) > This is WebKit2 code, and WebKit2 does not support Windows. That would be > large undertaking, which should be discussed on webkit-dev before starting. You are right if we are going to support WebKit2 on Windows, but this patch does not intend to do such a thing. I think it would not be a harm to use existing platform abstraction of WTF.
Alex Christensen
Comment 8 2017-06-13 12:50:43 PDT
This is like https://bugs.webkit.org/show_bug.cgi?id=172667#c8 I want to keep accepting patches like this, but discuss on webkit-dev before deciding if we want to officially support large amounts of code.
Note You need to log in before you can comment on or make changes to this bug.