| Summary: | [WebCrypto] Remove unsupported CryptoAlgorithmIdentifier | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||
| Component: | WebCore Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alecflett, beidson, bfulgham, buildbot, commit-queue, jiewen_tan, jonlee, jsbell, webkit-bug-importer, zan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 166746 | ||||||
| Attachments: |
|
||||||
|
Description
Jiewen Tan
2017-06-08 21:58:41 PDT
Created attachment 312379 [details]
Patch
Attachment 312379 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:233: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:234: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:235: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:236: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:237: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:238: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:239: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:240: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:241: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:242: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:243: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 11 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 312379 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312379&action=review > Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp:-319 > - case CryptoAlgorithmIdentifier::AES_CMAC: When we remove these cases, do we have a general error handler that reports to the user that it is an unsupported algorithm? If so, r=me. Comment on attachment 312379 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312379&action=review Thanks Brent for r+ my patch. >> Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp:-319 >> - case CryptoAlgorithmIdentifier::AES_CMAC: > > When we remove these cases, do we have a general error handler that reports to the user that it is an unsupported algorithm? > > If so, r=me. Yes, we do. Comment on attachment 312379 [details] Patch Clearing flags on attachment: 312379 Committed r218030: <http://trac.webkit.org/changeset/218030> All reviewed patches have been landed. Closing bug. this breaks Netflix. |