Bug 172962

Summary: Add a version number to ARES-6
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rniwa, ticaiolima, ysuzuki
Priority: P2    
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172960    
Attachments:
Description Flags
patch
none
patch none

Saam Barati
Reported 2017-06-05 23:45:19 PDT
...
Attachments
patch (2.00 KB, patch)
2017-06-05 23:59 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (2.28 KB, patch)
2017-06-06 00:17 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-06-05 23:59:20 PDT
Created attachment 312060 [details] patch
Yusuke Suzuki
Comment 2 2017-06-06 00:01:58 PDT
Comment on attachment 312060 [details] patch How about adding this number to benchmark driver in JS? It allows us to 1. Keep in sync with JS code change & ARES-6 version number. 2. Provide a way to print version number even in cli.js
Saam Barati
Comment 3 2017-06-06 00:17:46 PDT
Created attachment 312061 [details] patch
Yusuke Suzuki
Comment 4 2017-06-06 00:18:25 PDT
Comment on attachment 312061 [details] patch r=me
WebKit Commit Bot
Comment 5 2017-06-06 00:57:48 PDT
Comment on attachment 312061 [details] patch Clearing flags on attachment: 312061 Committed r217822: <http://trac.webkit.org/changeset/217822>
WebKit Commit Bot
Comment 6 2017-06-06 00:57:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.