Bug 172960

Summary: ARES-6 incorrectly measures Worst 4 Iterations
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rniwa, ticaiolima, ysuzuki
Priority: P2    
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 172962    
Bug Blocks:    
Attachments:
Description Flags
patch mark.lam: review+

Saam Barati
Reported 2017-06-05 23:18:04 PDT
It accidentally measures first 4.
Attachments
patch (2.77 KB, patch)
2017-06-05 23:22 PDT, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-06-05 23:22:57 PDT
Created attachment 312059 [details] patch
Mark Lam
Comment 2 2017-06-05 23:28:12 PDT
Comment on attachment 312059 [details] patch r=me
Ryosuke Niwa
Comment 3 2017-06-05 23:31:33 PDT
Comment on attachment 312059 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=312059&action=review > PerformanceTests/ARES-6/results.js:59 > We should version benchmarks. Otherwise, people can't tell which version of the benchmark they're running.
Saam Barati
Comment 4 2017-06-07 12:14:03 PDT
landed in: https://trac.webkit.org/changeset/217897/webkit
Note You need to log in before you can comment on or make changes to this bug.