Bug 172598

Summary: Prevent async methods named 'function'
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: GSkachkov <gskachkov>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, caitp, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, joepeck, keith_miller, littledan, mark.lam, msaboff, saam, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172660, 172776    
Attachments:
Description Flags
Patch
none
Patch none

Saam Barati
Reported 2017-05-25 10:45:39 PDT
See https://github.com/tc39/ecma262/pull/884?
Attachments
Patch (6.31 KB, patch)
2017-05-25 12:59 PDT, GSkachkov 		no flags
DetailsFormatted DiffDiff
Patch (6.45 KB, patch)
2017-05-25 13:12 PDT, GSkachkov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
GSkachkov
Comment 1 2017-05-25 12:59:52 PDT
Created attachment 311271 [details] Patch Patch
Mark Lam
Comment 2 2017-05-25 13:06:01 PDT
Comment on attachment 311271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311271&action=review > Source/JavaScriptCore/ChangeLog:3 > + Prevent async methods named âfunctionâ Please fix non-ascii characters in the description. Please also add a url to the spec or maybe https://github.com/tc39/ecma262/pull/884 that specifies this behavior.
Mark Lam
Comment 3 2017-05-25 13:06:24 PDT
Comment on attachment 311271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311271&action=review > JSTests/ChangeLog:3 > + Prevent async methods named âfunctionâ Ditto for non-ascii characters.
GSkachkov
Comment 4 2017-05-25 13:12:37 PDT
Created attachment 311274 [details] Patch Patch with fixes
GSkachkov
Comment 5 2017-05-25 13:13:12 PDT
Comment on attachment 311271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311271&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + Prevent async methods named âfunctionâ > > Please fix non-ascii characters in the description. > > Please also add a url to the spec or maybe https://github.com/tc39/ecma262/pull/884 that specifies this behavior. Fixed >> JSTests/ChangeLog:3 >> + Prevent async methods named âfunctionâ > > Ditto for non-ascii characters. Oh, it seems that taken from task name. Fixed
Mark Lam
Comment 6 2017-05-25 13:19:25 PDT
Comment on attachment 311274 [details] Patch r=me
WebKit Commit Bot
Comment 7 2017-05-26 00:00:48 PDT
Comment on attachment 311274 [details] Patch Clearing flags on attachment: 311274 Committed r217478: <http://trac.webkit.org/changeset/217478>
WebKit Commit Bot
Comment 8 2017-05-26 00:00:49 PDT
All reviewed patches have been landed. Closing bug.
Saam Barati
Comment 9 2017-05-26 01:34:28 PDT
Comment on attachment 311274 [details] Patch Does this effect Object liberals? If so, please add a test
GSkachkov
Comment 10 2017-05-26 13:03:01 PDT
Yeah?(In reply to Saam Barati from comment #9) > Comment on attachment 311274 [details] > Patch > > Does this effect Object liberals? If so, please add a test Yeah you are right, I was focused on class methods, but spec cover object literals as well https://github.com/tc39/test262/pull/967/files#diff-0fc4f159cc11cd6471944c682729ff0dR17 I've prepared fix, expect to upload it to separate issue tomorrow. Thanks for comment.
GSkachkov
Comment 11 2017-05-28 13:01:26 PDT
(In reply to Saam Barati from comment #9) > Comment on attachment 311274 [details] > Patch > > Does this effect Object liberals? If so, please add a test There is a patch that cover object literals https://bugs.webkit.org/show_bug.cgi?id=172660
Radar WebKit Bug Importer
Comment 12 2017-05-30 20:21:43 PDT
<rdar://problem/32479725>
Daniel Ehrenberg
Comment 13 2017-05-31 07:56:05 PDT
We reviewed this PR at TC39 and decided *not* to do this spec change, and to leave things as is, permitting async methods named function. Sorry for the confusion.
JF Bastien
Comment 14 2017-05-31 10:15:19 PDT
(In reply to Daniel Ehrenberg from comment #13) > We reviewed this PR at TC39 and decided *not* to do this spec change, and to > leave things as is, permitting async methods named function. Sorry for the > confusion. Thanks for catching this! Reference: https://github.com/tc39/ecma262/pull/884
GSkachkov
Comment 15 2017-05-31 11:30:12 PDT
(In reply to Daniel Ehrenberg from comment #13) > We reviewed this PR at TC39 and decided *not* to do this spec change, and to > leave things as is, permitting async methods named function. Sorry for the > confusion. Ups. Will do rollback. Thanks for update.
Note You need to log in before you can comment on or make changes to this bug.