Bug 172588

Summary: [ATK] Add support for aria-details and aria-errormessage
Product: WebKit Reporter: Joanmarie Diggs <jdiggs>
Component: AccessibilityAssignee: Joanmarie Diggs <jdiggs>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cdumez, cfleizach, commit-queue, dmazzoni, esprehn+autocc, gyuyoung.kim, jcraig, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Linux   
Bug Depends on: 155494, 172355    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Joanmarie Diggs 2017-05-25 07:13:04 PDT
The aria-details attribute was added in ARIA 1.1. According to the Core AAM [1]:

"If the referenced object is in the accessibility tree, expose a pointer to the accessible object using RELATION_DETAILS, and expose reverse relations as described in Relations."

The reverse relation type for RELATION_DETAILS is RELATION_DETAILS_FOR.

[1] https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaDetails
Comment 1 Radar WebKit Bug Importer 2017-05-25 07:13:22 PDT
<rdar://problem/32401029>
Comment 2 Joanmarie Diggs 2017-05-25 07:17:19 PDT
Note that the relation types needed to implement this support will require we update the minimum versions of atk, at-spi2-core, and at-spi2-atk in jhbuild to at least 2.15.2. That also needs to be done in order to fix bug 172355, for which there is a proposed patch. Therefore making this bug depend on 172355.
Comment 3 Joanmarie Diggs 2017-06-02 05:55:16 PDT
(Combining bugs since the implementation of aria-details and aria-errormessage should be simple, small, and quite similar and share the same dependencies.)

The aria-errormessage attribute was added in ARIA 1.1. According to the Core AAM [1]:

"If the referenced object is in the accessibility tree, expose a pointer to the accessible object using RELATION_ERROR_MESSAGE, and expose reverse relations as described in Relations."

The reverse relation type for RELATION_ERROR_MESSAGE is RELATION_ERROR_FOR.

Note that the relation types needed to implement this support will require we update the minimum versions of atk, at-spi2-core, and at-spi2-atk in jhbuild to at least 2.15.2. That also needs to be done in order to fix bug 172355, for which there is a proposed patch. Therefore making this bug depend on 172355.

[1] https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaErrorMessage
Comment 4 Joanmarie Diggs 2017-06-02 05:55:35 PDT
*** Bug 172589 has been marked as a duplicate of this bug. ***
Comment 5 Joanmarie Diggs 2017-06-02 05:59:05 PDT
Fixing this depends on fixing bug 155494 because the implementation requires reverse relations.
Comment 6 Joanmarie Diggs 2017-06-26 04:53:40 PDT
Created attachment 313825 [details]
Patch
Comment 7 Build Bot 2017-06-26 04:56:05 PDT
Attachment 313825 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:206:  'ariaDetailsElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'.  [readability/naming/protected] [4]
ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:207:  'ariaDetailsReferencingElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'.  [readability/naming/protected] [4]
ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:208:  'ariaErrorMessageElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'.  [readability/naming/protected] [4]
ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:209:  'ariaErrorMessageReferencingElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'.  [readability/naming/protected] [4]
Total errors found: 4 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Joanmarie Diggs 2017-06-26 05:00:26 PDT
(In reply to Build Bot from comment #7)

> If any of these errors are false positives, please file a bug against
> check-webkit-style.

They are either false positives or we need to rename a bunch of methods in WKTR and update many of the accessibility Layout Tests which call those methods. If it's the latter case, it goes beyond the scope of this bug.
Comment 9 Joanmarie Diggs 2017-06-26 07:45:17 PDT
Created attachment 313837 [details]
Patch
Comment 10 Build Bot 2017-06-26 07:47:52 PDT
Attachment 313837 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:206:  'ariaDetailsElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'.  [readability/naming/protected] [4]
ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:207:  'ariaDetailsReferencingElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'.  [readability/naming/protected] [4]
ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:208:  'ariaErrorMessageElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'.  [readability/naming/protected] [4]
ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:209:  'ariaErrorMessageReferencingElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'.  [readability/naming/protected] [4]
Total errors found: 4 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 WebKit Commit Bot 2017-06-26 09:45:38 PDT
Comment on attachment 313837 [details]
Patch

Clearing flags on attachment: 313837

Committed r218809: <http://trac.webkit.org/changeset/218809>
Comment 12 WebKit Commit Bot 2017-06-26 09:45:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 James Craig 2019-09-26 12:11:26 PDT
*** Bug 165190 has been marked as a duplicate of this bug. ***