Bug 172355

Summary: [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
Product: WebKit Reporter: Joanmarie Diggs <jdiggs>
Component: AccessibilityAssignee: Joanmarie Diggs <jdiggs>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cfleizach, commit-queue, csaavedra, dmazzoni, jcraig, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: Linux   
Bug Depends on:    
Bug Blocks: 172588, 172589    
Attachments:
Description Flags
Patch
none
Patch none

Joanmarie Diggs
Reported 2017-05-19 03:45:22 PDT
The DPub ARIA "doc-footnote" role should be exposed with ATK_ROLE_FOOTNOTE. This was not done during the initial implementation because there was not (yet) a ROLE_FOOTNOTE in ATK or AT-SPI2. That new role landed in ATK and AT-SPI2 today and should be included in the next unstable releases of those modules. Once the role is available in a release, we can expose doc-footnote with the new platform role.
Attachments
Patch (10.27 KB, patch)
2017-05-25 05:33 PDT, Joanmarie Diggs 		no flags
DetailsFormatted DiffDiff
Patch (11.08 KB, patch)
2017-05-25 08:57 PDT, Joanmarie Diggs 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-05-19 03:45:52 PDT
<rdar://problem/32291847>
Joanmarie Diggs
Comment 2 2017-05-25 05:33:02 PDT
Created attachment 311214 [details] Patch
Joanmarie Diggs
Comment 3 2017-05-25 08:57:12 PDT
Created attachment 311224 [details] Patch
WebKit Commit Bot
Comment 4 2017-05-25 09:43:27 PDT
Comment on attachment 311224 [details] Patch Clearing flags on attachment: 311224 Committed r217426: <http://trac.webkit.org/changeset/217426>
WebKit Commit Bot
Comment 5 2017-05-25 09:43:28 PDT
All reviewed patches have been landed. Closing bug.
Claudio Saavedra
Comment 6 2017-05-25 09:55:44 PDT
Committed r217428: <http://trac.webkit.org/changeset/217428>
Claudio Saavedra
Comment 7 2017-05-25 09:57:05 PDT
(In reply to Claudio Saavedra from comment #6) > Committed r217428: <http://trac.webkit.org/changeset/217428> I have no idea what happened here, I just landed a new baseline with 'webkit-patch land' and it edited this bug. :/
Joanmarie Diggs
Comment 8 2017-05-25 10:16:21 PDT
(In reply to Claudio Saavedra from comment #7) > (In reply to Claudio Saavedra from comment #6) > > Committed r217428: <http://trac.webkit.org/changeset/217428> > > I have no idea what happened here, I just landed a new baseline with > 'webkit-patch land' and it edited this bug. :/ Yay technology. It doesn't appear to have changed my code, so whatever.
Note You need to log in before you can comment on or make changes to this bug.