Bug 172348

Summary:

Speedometer 2.0: Vanilla JS test doesn't mark all todo items as completed

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

addyo, cdumez, commit-queue, fpizlo, ggaren, koivisto, lforschler, saam

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

172339

Attachments:

Description	Flags
Fixes the bug	none

Description Ryosuke Niwa 2017-05-19 00:39:43 PDT

The problem is that the memory storage class uses ms precision wall clock as a storage ID.
Because we're adding 50 items at all once, some items would inevitably end up having the same ID.
This results in multiple todo items sharing a single ID and cause havoc.

Use a monotonically increasing number as an ID instead.

Comment 1 Ryosuke Niwa 2017-05-19 00:42:48 PDT

Created attachment 310629 [details]
Fixes the bug

Comment 2 Antti Koivisto 2017-05-19 01:51:12 PDT

Comment on attachment 310629 [details]
Fixes the bug

r=me

Comment 3 WebKit Commit Bot 2017-05-19 02:19:05 PDT

Comment on attachment 310629 [details]
Fixes the bug

Clearing flags on attachment: 310629

Committed r217107: <http://trac.webkit.org/changeset/217107>

Comment 4 WebKit Commit Bot 2017-05-19 02:19:07 PDT

All reviewed patches have been landed.  Closing bug.