Bug 172347

Summary:

Speedometer 2.0: Flight.js test is sometime broken

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

addyo, cdumez, commit-queue, fpizlo, ggaren, koivisto, lforschler, saam

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

172339

Attachments:

Description	Flags
Fixes the test	none
Wait for dependencies to load	koivisto: review+, rniwa: commit-queue+

Description Ryosuke Niwa 2017-05-19 00:24:42 PDT

Flight.js test is flaky because it doesn't always wait for the app to be ready.
We need to add the same hack as v1 to wait for all dependencies to be loaded via require.js

Comment 1 Ryosuke Niwa 2017-05-19 00:29:58 PDT

Created attachment 310628 [details]
Fixes the test

Comment 2 Antti Koivisto 2017-05-19 01:56:56 PDT

Comment on attachment 310628 [details]
Fixes the test

r=me

Comment 3 Ryosuke Niwa 2017-05-19 02:49:55 PDT

Created attachment 310641 [details]
Wait for dependencies to load

Comment 4 Ryosuke Niwa 2017-05-19 03:05:14 PDT

Committed r217118: <http://trac.webkit.org/changeset/217118>