Bug 172294

Summary: [JSC] Remove PLATFORM(WIN) references
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: JavaScriptCoreAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, keith_miller, mark.lam, msaboff, pvollan, saam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172144    
Attachments:
Description Flags
Patch none

Description Don Olmstead 2017-05-18 11:17:28 PDT 
PLATFORM(WIN) should not be used when OS(WINDOWS) can be used.
Comment 1 Don Olmstead 2017-05-18 11:18:11 PDT 
Blocks compilation of JSCOnly on Windows.
Comment 2 Don Olmstead 2017-05-18 11:24:43 PDT 
Created attachment 310521 [details]
Patch

Using OS(WINDOWS) instead of PLATFORM(WIN).

Updated Offline ASM to check for MSVC instead of PLATFORM(WIN) for MASM.
Comment 3 Konstantin Tokarev 2017-05-18 11:40:10 PDT 
LGTM
Comment 4 Yusuke Suzuki 2017-05-19 02:11:46 PDT 
Comment on attachment 310521 [details]
Patch

OK, r=me
Comment 5 WebKit Commit Bot 2017-05-19 02:39:31 PDT 
Comment on attachment 310521 [details]
Patch

Clearing flags on attachment: 310521

Committed r217109: <http://trac.webkit.org/changeset/217109>
Comment 6 WebKit Commit Bot 2017-05-19 02:39:33 PDT 
All reviewed patches have been landed.  Closing bug.