Bug 172294

Summary: [JSC] Remove PLATFORM(WIN) references
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: JavaScriptCoreAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, keith_miller, mark.lam, msaboff, pvollan, saam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172144    
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2017-05-18 11:17:28 PDT
PLATFORM(WIN) should not be used when OS(WINDOWS) can be used.
Attachments
Patch (4.15 KB, patch)
2017-05-18 11:24 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-05-18 11:18:11 PDT
Blocks compilation of JSCOnly on Windows.
Don Olmstead
Comment 2 2017-05-18 11:24:43 PDT
Created attachment 310521 [details] Patch Using OS(WINDOWS) instead of PLATFORM(WIN). Updated Offline ASM to check for MSVC instead of PLATFORM(WIN) for MASM.
Konstantin Tokarev
Comment 3 2017-05-18 11:40:10 PDT
LGTM
Yusuke Suzuki
Comment 4 2017-05-19 02:11:46 PDT
Comment on attachment 310521 [details] Patch OK, r=me
WebKit Commit Bot
Comment 5 2017-05-19 02:39:31 PDT
Comment on attachment 310521 [details] Patch Clearing flags on attachment: 310521 Committed r217109: <http://trac.webkit.org/changeset/217109>
WebKit Commit Bot
Comment 6 2017-05-19 02:39:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.