Bug 172253

Summary: [Cocoa] errors are not propagated to PassKit when calling ApplePaySession.completePayment()
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, ggaren, mitz, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=169427
https://bugs.webkit.org/show_bug.cgi?id=172256
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2017-05-17 16:39:04 PDT
[Cocoa] errors are not propogated to PassKit when calling ApplePaySession.completePayment()
Attachments
Patch (2.42 KB, patch)
2017-05-17 16:46 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (2.42 KB, patch)
2017-05-17 17:17 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-05-17 16:41:25 PDT
rdar://problem/32258020
Andy Estes
Comment 2 2017-05-17 16:46:11 PDT
Created attachment 310461 [details] Patch
Andy Estes
Comment 3 2017-05-17 16:48:56 PDT
Comment on attachment 310461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310461&action=review > Source/WebCore/ChangeLog:3 > + [Cocoa] errors are not propogated to PassKit when calling ApplePaySession.completePayment() Will fix my shameful spelling error before landing.
mitz
Comment 4 2017-05-17 17:08:20 PDT
Can we make it a runtime error to call releaseReturnValue a second time, at least in Debug builds?
Andy Estes
Comment 5 2017-05-17 17:15:40 PDT
(In reply to mitz from comment #4) > Can we make it a runtime error to call releaseReturnValue a second time, at > least in Debug builds? I filed https://bugs.webkit.org/show_bug.cgi?id=172256 Thanks for the review!
Andy Estes
Comment 6 2017-05-17 17:17:12 PDT
Created attachment 310466 [details] Patch
WebKit Commit Bot
Comment 7 2017-05-17 17:58:57 PDT
Comment on attachment 310466 [details] Patch Clearing flags on attachment: 310466 Committed r217022: <http://trac.webkit.org/changeset/217022>
WebKit Commit Bot
Comment 8 2017-05-17 17:58:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.