| Summary: | [Cocoa] errors are not propagated to PassKit when calling ApplePaySession.completePayment() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, bdakin, commit-queue, ggaren, mitz, sam, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=169427 https://bugs.webkit.org/show_bug.cgi?id=172256 |
||||||||
| Attachments: |
|
||||||||
|
Description
Andy Estes
2017-05-17 16:39:04 PDT
Created attachment 310461 [details]
Patch
Comment on attachment 310461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310461&action=review > Source/WebCore/ChangeLog:3 > + [Cocoa] errors are not propogated to PassKit when calling ApplePaySession.completePayment() Will fix my shameful spelling error before landing. Can we make it a runtime error to call releaseReturnValue a second time, at least in Debug builds? (In reply to mitz from comment #4) > Can we make it a runtime error to call releaseReturnValue a second time, at > least in Debug builds? I filed https://bugs.webkit.org/show_bug.cgi?id=172256 Thanks for the review! Created attachment 310466 [details]
Patch
Comment on attachment 310466 [details] Patch Clearing flags on attachment: 310466 Committed r217022: <http://trac.webkit.org/changeset/217022> All reviewed patches have been landed. Closing bug. |