Bug 172215

Summary: Use the parent box style to adjust RenderStyle for alignment.
Product: WebKit Reporter: Emilio Cobos Álvarez <ecobos>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, jfernandez, koivisto, rego, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 171984, 172212    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Emilio Cobos Álvarez
Reported 2017-05-17 03:37:46 PDT
Blocked on the display contents RuntimeEnabledFeature (bug 171984), and the css-display-3 tests (bug 172212).
Attachments
Patch (7.50 KB, patch)
2017-05-17 03:44 PDT, Emilio Cobos Álvarez 		no flags
DetailsFormatted DiffDiff
Patch (7.44 KB, patch)
2017-05-23 11:08 PDT, Emilio Cobos Álvarez 		no flags
DetailsFormatted DiffDiff
Patch (7.45 KB, patch)
2017-05-29 04:40 PDT, Emilio Cobos Álvarez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (11.60 MB, application/zip)
2017-05-29 06:05 PDT, Build Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Emilio Cobos Álvarez
Comment 1 2017-05-17 03:44:49 PDT
Created attachment 310377 [details] Patch
Emilio Cobos Álvarez
Comment 2 2017-05-23 11:08:06 PDT
Created attachment 311027 [details] Patch
Emilio Cobos Álvarez
Comment 3 2017-05-29 04:40:27 PDT
Created attachment 311467 [details] Patch
Build Bot
Comment 4 2017-05-29 06:05:28 PDT
Comment on attachment 311467 [details] Patch Attachment 311467 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3836830 New failing tests: webrtc/peer-connection-audio-mute.html
Build Bot
Comment 5 2017-05-29 06:05:30 PDT
Created attachment 311470 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Emilio Cobos Álvarez
Comment 6 2017-05-29 06:28:43 PDT
(In reply to Build Bot from comment #4) > Comment on attachment 311467 [details] > Patch > > Attachment 311467 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: http://webkit-queues.webkit.org/results/3836830 > > New failing tests: > webrtc/peer-connection-audio-mute.html That definitely doesn't sound related to my changes :-). Is there any way of retrying it or something?
WebKit Commit Bot
Comment 7 2017-05-29 07:09:41 PDT
Comment on attachment 311467 [details] Patch Clearing flags on attachment: 311467 Committed r217536: <http://trac.webkit.org/changeset/217536>
WebKit Commit Bot
Comment 8 2017-05-29 07:09:42 PDT
All reviewed patches have been landed. Closing bug.
Antti Koivisto
Comment 9 2017-05-29 07:11:03 PDT
You can set cq+ again.
Radar WebKit Bug Importer
Comment 10 2017-05-30 20:27:43 PDT
<rdar://problem/32479836>
Note You need to log in before you can comment on or make changes to this bug.