Bug 171858

Summary:

Print more properties in the output of scrolling trees

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

WebKit Misc.

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cmarcelo, commit-queue, jamesr, luiz, rniwa, simon.fraser, tonikitoo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

171802, 171848

Bug Blocks:

Attachments:

Description	Flags
Patch	simon.fraser: review+, buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Patch for landing	fred.wang: commit-queue-
Patch for landing	none

Frédéric Wang (:fredw)

Reported 2017-05-09 07:52:26 PDT

void ScrollingStateFrameScrollingNode::dumpProperties(TextStream& ts, ScrollingStateTreeAsTextBehavior behavior) const { [...] // FIXME: dump more properties. }

Attachments
Patch (47.94 KB, patch) 2017-05-09 08:06 PDT, Frédéric Wang (:fredw)	simon.fraser: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (900.46 KB, application/zip) 2017-05-09 09:17 PDT, Build Bot	no flags	Details
Patch for landing (49.46 KB, patch) 2017-05-09 09:27 PDT, Frédéric Wang (:fredw)	fred.wang: commit-queue-	Details Formatted Diff Diff
Patch for landing (49.46 KB, patch) 2017-05-09 09:29 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2017-05-09 08:06:22 PDT

Created attachment 309496 [details] Patch

Build Bot

Comment 2 2017-05-09 09:17:19 PDT

Comment on attachment 309496 [details] Patch Attachment 309496 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3706053 New failing tests: tiled-drawing/scrolling/fixed/four-bars-zoomed.html

Build Bot

Comment 3 2017-05-09 09:17:20 PDT

Created attachment 309504 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Frédéric Wang (:fredw)

Comment 4 2017-05-09 09:27:33 PDT

Created attachment 309506 [details] Patch for landing

Frédéric Wang (:fredw)

Comment 5 2017-05-09 09:29:02 PDT

Created attachment 309507 [details] Patch for landing

Frédéric Wang (:fredw)

Comment 6 2017-05-09 09:29:18 PDT

Comment on attachment 309506 [details] Patch for landing wrong patch

WebKit Commit Bot

Comment 7 2017-05-09 10:11:01 PDT

Comment on attachment 309507 [details] Patch for landing Clearing flags on attachment: 309507 Committed r216511: <http://trac.webkit.org/changeset/216511>

Frédéric Wang (:fredw)

Comment 8 2017-10-30 08:13:57 PDT

It looks like this bug was fixed, so closing it.

Radar WebKit Bug Importer

Comment 9 2017-11-15 13:10:58 PST

<rdar://problem/35568925>

Note You need to log in before you can comment on or make changes to this bug.