Bug 171751

Summary: [WTF] Do not export deleted constructor in StringView
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Web Template FrameworkAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 171618    
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2017-05-05 14:30:53 PDT
Microsoft export macros should not be applied to deleted functions. MSVC ignores this but clang-cl throws an error.
Attachments
Patch (963 bytes, patch)
2017-05-05 14:39 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-05-05 14:39:55 PDT
Created attachment 309213 [details] Patch
WebKit Commit Bot
Comment 2 2017-05-05 17:08:57 PDT
Comment on attachment 309213 [details] Patch Clearing flags on attachment: 309213 Committed r216298: <http://trac.webkit.org/changeset/216298>
WebKit Commit Bot
Comment 3 2017-05-05 17:08:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.