Bug 171751 - [WTF] Do not export deleted constructor in StringView
Summary: [WTF] Do not export deleted constructor in StringView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks: 171618
  Show dependency tree / graph
 
Reported: 2017-05-05 14:30 PDT by Don Olmstead
Modified: 2017-05-05 17:08 PDT (History)
6 users (show)

See Also:

Attachments
Patch (963 bytes, patch)
2017-05-05 14:39 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-05-05 14:30:53 PDT 
Microsoft export macros should not be applied to deleted functions. MSVC ignores this but clang-cl throws an error.
Comment 1 Don Olmstead 2017-05-05 14:39:55 PDT 
Created attachment 309213 [details]
Patch
Comment 2 WebKit Commit Bot 2017-05-05 17:08:57 PDT 
Comment on attachment 309213 [details]
Patch

Clearing flags on attachment: 309213

Committed r216298: <http://trac.webkit.org/changeset/216298>
Comment 3 WebKit Commit Bot 2017-05-05 17:08:59 PDT 
All reviewed patches have been landed.  Closing bug.