Bug 171721

Summary: [GStreamer] Fix handling of gst errors in MediaPlayerPrivateGStreamer::handleMessage
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch calvaris: review+

Carlos Garcia Campos
Reported 2017-05-05 03:54:49 PDT
We are checking the errors only by their code, which can be the same in other domains. We should always check both the domain and the code.
Attachments
Patch (2.99 KB, patch)
2017-05-05 03:56 PDT, Carlos Garcia Campos 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-05-05 03:56:43 PDT
Created attachment 309157 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2017-05-05 04:54:34 PDT
Comment on attachment 309157 [details] Patch I am curious, what does this fix?
Carlos Garcia Campos
Comment 3 2017-05-05 04:59:16 PDT
I noticed this while working on bug #171722, so I don't know what it fixed, but for example, if we receive a GST_RESOURCE_ERROR_OPEN_WRITE error, it will be handled as a format error because the code is the same as GST_STREAM_ERROR_CODEC_NOT_FOUND.
Carlos Garcia Campos
Comment 4 2017-05-05 05:02:44 PDT
Committed r216239: <http://trac.webkit.org/changeset/216239>
Michael Catanzaro
Comment 5 2017-05-05 05:45:58 PDT
It would be good to grep for other uses of GStreamer error codes to ensure we didn't make this same mistake in other places.
Carlos Garcia Campos
Comment 6 2017-05-05 05:59:48 PDT
(In reply to Michael Catanzaro from comment #5) > It would be good to grep for other uses of GStreamer error codes to ensure > we didn't make this same mistake in other places. I did it when I noticed the problem.
Note You need to log in before you can comment on or make changes to this bug.