Bug 171600 – [GTK] Test css3/filters/composited-during-animation-layertree.html is flaky since r214292

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

Sometimes the results include an extra layer

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/css3/filters/composited-during-animation-layertree-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/css3/filters/composited-during-animation-layertree-actual.txt
@@ -2,4 +2,32 @@
    
    
   
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 800.00 600.00)
+  (children 1
+    (GraphicsLayer
+      (bounds 800.00 600.00)
+      (contentsOpaque 1)
+      (children 4
+        (GraphicsLayer
+          (position 18.00 18.00)
+          (bounds 160.00 90.00)
+        )
+        (GraphicsLayer
+          (position 18.00 131.00)
+          (bounds 160.00 90.00)
+        )
+        (GraphicsLayer
+          (position 18.00 244.00)
+          (bounds 160.00 90.00)
+        )
+        (GraphicsLayer
+          (position 18.00 357.00)
+          (bounds 160.00 90.00)
+        )
+      )
+    )
+  )
+)
 
Actually r214296 is the revision when all css3 filters tests where enabled

[Diego Pino]

The general baseline for this test is empty. This seems like a mistake to me (See: https://bugs.webkit.org/show_bug.cgi?id=95622#c2).

The only port that has a specific baseline for this test is 'Mac'. The baseline is similar to GLIB:

$ diff LayoutTests/platform/mac/css3/filters/composited-during-animation-layertree-expected.txt LayoutTests/platform/glib/css3/filters/composited-during-animation-layertree-
expected.txt
5a6
>   (anchor 0.00 0.00)
15d15
<           (drawsContent 1)
20d19
<           (drawsContent 1)
25d23
<           (drawsContent 1)
30d27
<           (drawsContent 1)

But the test is marked as flaky in Mac, so maybe the Mac baseline needs an update.

[Diego Pino]

Actually there's no glib baseline for this test at this moment, but there's a WPE baseline. WebKitGTK is producing the same baseline as WPE, so they could be merged.

[Diego Pino]

Created attachment 430924 [details]
Patch

[Diego Pino]

Created attachment 430960 [details]
Patch

[EWS]

Found 1 new test failure: imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html

[Diego Pino]

Created attachment 431157 [details]
Patch

[EWS]

Committed r278757 (238718@main): <https://commits.webkit.org/238718@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431157 [details].