Bug 171588

Summary: Make the [EnabledBySetting] extended attribute work for any attribute or operation on a prototype
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148363    
Attachments:
Description Flags
Patch none

Sam Weinig
Reported Wednesday, May 3, 2017 2:11:17 AM UTC
Make the [EnabledBySetting] extended attribute work for any attribute or operation on a prototype
Attachments
Patch (136.22 KB, patch)
2017-05-02 18:23 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 Wednesday, May 3, 2017 2:23:41 AM UTC
Created attachment 308876 [details] Patch
Dean Jackson
Comment 2 Thursday, May 4, 2017 6:55:04 PM UTC
Comment on attachment 308876 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308876&action=review > Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:2891 > +} > + > +#endif Nit: the #if had no blank line before the code. > Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4564 > + > +#endif ditto
WebKit Commit Bot
Comment 3 Thursday, May 4, 2017 7:39:07 PM UTC
Comment on attachment 308876 [details] Patch Clearing flags on attachment: 308876 Committed r216198: <http://trac.webkit.org/changeset/216198>
WebKit Commit Bot
Comment 4 Thursday, May 4, 2017 7:39:09 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.