Bug 171512

Summary: Stop using sprintf() in JavaScriptCore debugger
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, glenn, keith_miller, lforschler, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 171494    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2017-05-01 13:56:11 PDT
$ ./Tools/Scripts/check-webkit-style --filter="-,+security/" Source/JavaScriptCore
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86.c:175:  Never use sprintf.  Use snprintf instead.  [security/printf] [5]
Total errors found: 1 in 2781 files

Found via re-enabled checkers from Bug 171494.
Comment 1 David Kilzer (:ddkilzer) 2017-05-01 15:17:24 PDT
Created attachment 308774 [details]
Patch v1
Comment 2 Keith Miller 2017-05-01 17:31:21 PDT
Comment on attachment 308774 [details]
Patch v1

r=me.
Comment 3 WebKit Commit Bot 2017-05-01 18:00:38 PDT
Comment on attachment 308774 [details]
Patch v1

Clearing flags on attachment: 308774

Committed r216049: <http://trac.webkit.org/changeset/216049>
Comment 4 WebKit Commit Bot 2017-05-01 18:00:40 PDT
All reviewed patches have been landed.  Closing bug.