Bug 171512

Summary: Stop using sprintf() in JavaScriptCore debugger
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, glenn, keith_miller, lforschler, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 171494    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2017-05-01 13:56:11 PDT
$ ./Tools/Scripts/check-webkit-style --filter="-,+security/" Source/JavaScriptCore ERROR: Source/JavaScriptCore/disassembler/udis86/udis86.c:175: Never use sprintf. Use snprintf instead. [security/printf] [5] Total errors found: 1 in 2781 files Found via re-enabled checkers from Bug 171494.
Attachments
Patch v1 (3.64 KB, patch)
2017-05-01 15:17 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2017-05-01 15:17:24 PDT
Created attachment 308774 [details] Patch v1
Keith Miller
Comment 2 2017-05-01 17:31:21 PDT
Comment on attachment 308774 [details] Patch v1 r=me.
WebKit Commit Bot
Comment 3 2017-05-01 18:00:38 PDT
Comment on attachment 308774 [details] Patch v1 Clearing flags on attachment: 308774 Committed r216049: <http://trac.webkit.org/changeset/216049>
WebKit Commit Bot
Comment 4 2017-05-01 18:00:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.