Bug 171494

Summary: check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, buildbot, commit-queue, dbates, ddkilzer, glenn, joepeck, mitz, sam, wilander
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=170994
Bug Depends on:    
Bug Blocks: 171512, 171517, 171520    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2017-05-01 06:47:38 PDT
I'm guessing these checks were disabled because all of the "runtime/printf" checks together were too verbose when the original check-webkit-style was committed in 2009 in r45857. However, this meant that functions like strcat() and strcpy() were allowed to be committed into the WebKit tree at various times (see Bug 170994). We should turn these checks back on under a new category.
Attachments
Patch v1 (5.37 KB, patch)
2017-05-01 06:54 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2017-05-01 06:54:43 PDT
Created attachment 308719 [details] Patch v1
Brent Fulgham
Comment 2 2017-05-01 09:36:29 PDT
Comment on attachment 308719 [details] Patch v1 r=me.
WebKit Commit Bot
Comment 3 2017-05-01 10:06:43 PDT
Comment on attachment 308719 [details] Patch v1 Clearing flags on attachment: 308719 Committed r216017: <http://trac.webkit.org/changeset/216017>
WebKit Commit Bot
Comment 4 2017-05-01 10:06:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.