Summary: | AX: Inconsistent exposure of ARIA "button" role with non-false value of aria-haspopup | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joanmarie Diggs <jdiggs> | ||||
Component: | Accessibility | Assignee: | Joanmarie Diggs <jdiggs> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, samuel_white, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joanmarie Diggs
2017-04-23 14:34:37 PDT
Chris: If you think that ARIA buttons with a valid, non-false value of aria-haspopup should always be exposed on your platform as: AXRole: AXPopUpButton AXSubrole: <nil> AXRoleDescription: 'pop up button' Then I have good news: I apparently fixed this bug as a side effect of the changes made for bug 171164. It looks like we need a layout test for your platform since the above change wasn't caught. Before I do that, could you please confirm that I fixed something on your platform rather than broke it? If I broke it, then I'll of course accompany the new layout test with the restoration of the AXButton mapping. Thanks! (In reply to Joanmarie Diggs (irc: joanie) from comment #2) > Chris: If you think that ARIA buttons with a valid, non-false value of > aria-haspopup should always be exposed on your platform as: > > AXRole: AXPopUpButton > AXSubrole: <nil> > AXRoleDescription: 'pop up button' > > Then I have good news: I apparently fixed this bug as a side effect of the > changes made for bug 171164. > > It looks like we need a layout test for your platform since the above change > wasn't caught. Before I do that, could you please confirm that I fixed > something on your platform rather than broke it? If I broke it, then I'll of > course accompany the new layout test with the restoration of the AXButton > mapping. > > Thanks! I think that sounds correct. Presumably something still pops up when the button is pressed, so we call it a popup button Created attachment 308390 [details]
Patch
Comment on attachment 308390 [details] Patch Clearing flags on attachment: 308390 Committed r215873: <http://trac.webkit.org/changeset/215873> All reviewed patches have been landed. Closing bug. |