Bug 171183

Summary:

AX: Implement support for ARIA "figure" and "term" roles; update AXRoleDescription mapping for "feed" role

Product:

WebKit

Reporter:

Joanmarie Diggs <jdiggs>

Component:

Accessibility

Assignee:

Joanmarie Diggs <jdiggs>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Joanmarie Diggs

Reported 2017-04-22 19:12:37 PDT

According to https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#role-map-figure: WebKitGtk: ROLE_PANEL + object attribute xml-roles:figure Mac: AXRole: AXGroup, AXSubrole: <nil>, AXRoleDescription: 'figure'

Attachments
Patch (24.32 KB, patch) 2017-04-30 06:32 PDT, Joanmarie Diggs	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-04-22 19:12:54 PDT

<rdar://problem/31776037>

Joanmarie Diggs

Comment 2 2017-04-30 05:44:38 PDT

https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#role-map-term states: For Mac: AXRole: AXGroup AXSubrole: AXTerm AXRoleDescription: 'term' For WebKitGtk: ROLE_DESCRIPTION_TERM Interfaces: AtkText; AtkHypertext

Joanmarie Diggs

Comment 3 2017-04-30 05:44:55 PDT

*** Bug 171173 has been marked as a duplicate of this bug. ***

Joanmarie Diggs

Comment 4 2017-04-30 05:47:53 PDT

As stated in bug 151691 comment 9: > > Todo: Implement a new 'feedRole' in WebKit, a with macOS platform mapping of: > > > > AXRole: AXGroup > > AXSubrole: AXApplicationGroup > > The above is already done. > > > AXRoleDescription: 'feed' > > This will need to be done. Currently it is 'group'. Assigning to myself. > Will do a new patch, along with some other new roles, tomorrow. > > Thanks for the update!

Joanmarie Diggs

Comment 5 2017-04-30 06:32:27 PDT

Created attachment 308690 [details] Patch

Joanmarie Diggs

Comment 6 2017-04-30 06:33:57 PDT

*** Bug 151691 has been marked as a duplicate of this bug. ***

Joanmarie Diggs

Comment 7 2017-04-30 22:04:30 PDT

Chris: Please review. Thanks!

WebKit Commit Bot

Comment 8 2017-05-01 00:49:27 PDT

Comment on attachment 308690 [details] Patch Clearing flags on attachment: 308690 Committed r216007: <http://trac.webkit.org/changeset/216007>

WebKit Commit Bot

Comment 9 2017-05-01 00:49:28 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.