Bug 171076

Summary: Split cryptographic digest computation and parsing out of CSP code so it can be reused
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148363    
Attachments:
Description Flags
Patch
none
Patch
none
Patch cdumez: review+

Description Sam Weinig 2017-04-20 14:23:54 PDT
Split cryptographic digest computation and parsing out of CSP code so it can be reused
Comment 1 Sam Weinig 2017-04-20 14:48:23 PDT
Created attachment 307640 [details]
Patch
Comment 2 Sam Weinig 2017-04-20 15:07:58 PDT
Created attachment 307643 [details]
Patch
Comment 3 Sam Weinig 2017-04-20 15:35:12 PDT
Created attachment 307647 [details]
Patch
Comment 4 Chris Dumez 2017-04-21 13:42:43 PDT
Comment on attachment 307647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307647&action=review

r=me

> Source/WTF/wtf/text/Base64.h:154
> +WTF_EXPORT_PRIVATE bool base64Decode(const StringView&, SignedOrUnsignedCharVectorAdapter, unsigned options = Base64Default);

We usually take StringView in parameter, rather than const StringView& I believe.

> Source/WTF/wtf/text/Base64.h:192
> +WTF_EXPORT_PRIVATE bool base64URLDecode(const StringView&, SignedOrUnsignedCharVectorAdapter);

ditto.
Comment 5 Sam Weinig 2017-04-21 15:14:10 PDT
Committed revision 215646.