Bug 171076

Summary: Split cryptographic digest computation and parsing out of CSP code so it can be reused
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148363    
Attachments:
Description Flags
Patch
none
Patch
none
Patch cdumez: review+

Sam Weinig
Reported 2017-04-20 14:23:54 PDT
Split cryptographic digest computation and parsing out of CSP code so it can be reused
Attachments
Patch (32.09 KB, patch)
2017-04-20 14:48 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (32.13 KB, patch)
2017-04-20 15:07 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (33.59 KB, patch)
2017-04-20 15:35 PDT, Sam Weinig 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-04-20 14:48:23 PDT
Created attachment 307640 [details] Patch
Sam Weinig
Comment 2 2017-04-20 15:07:58 PDT
Created attachment 307643 [details] Patch
Sam Weinig
Comment 3 2017-04-20 15:35:12 PDT
Created attachment 307647 [details] Patch
Chris Dumez
Comment 4 2017-04-21 13:42:43 PDT
Comment on attachment 307647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307647&action=review r=me > Source/WTF/wtf/text/Base64.h:154 > +WTF_EXPORT_PRIVATE bool base64Decode(const StringView&, SignedOrUnsignedCharVectorAdapter, unsigned options = Base64Default); We usually take StringView in parameter, rather than const StringView& I believe. > Source/WTF/wtf/text/Base64.h:192 > +WTF_EXPORT_PRIVATE bool base64URLDecode(const StringView&, SignedOrUnsignedCharVectorAdapter); ditto.
Sam Weinig
Comment 5 2017-04-21 15:14:10 PDT
Committed revision 215646.
Note You need to log in before you can comment on or make changes to this bug.