Summary: | Split cryptographic digest computation and parsing out of CSP code so it can be reused | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, dbates | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 148363 | ||||||||||
Attachments: |
|
Description
Sam Weinig
2017-04-20 14:23:54 PDT
Created attachment 307640 [details]
Patch
Created attachment 307643 [details]
Patch
Created attachment 307647 [details]
Patch
Comment on attachment 307647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307647&action=review r=me > Source/WTF/wtf/text/Base64.h:154 > +WTF_EXPORT_PRIVATE bool base64Decode(const StringView&, SignedOrUnsignedCharVectorAdapter, unsigned options = Base64Default); We usually take StringView in parameter, rather than const StringView& I believe. > Source/WTF/wtf/text/Base64.h:192 > +WTF_EXPORT_PRIVATE bool base64URLDecode(const StringView&, SignedOrUnsignedCharVectorAdapter); ditto. Committed revision 215646. |