Bug 171034 – [Windows][WK1] Web Inspector: Timelines tab doesn't function at all

• Component: Web Inspector
• Status: RESOLVED WONTFIX

[Fujii Hironori]

[Windows] Web Inspector: Timelines tab doesn't function at all

AppleWin port and WinCairo port

Steps:

1) Open MiniBrowser
2) Open Web Inspector
3) Open Timelines tab
4) Push reload

Nothing happens in Timelines view.

Does some features need to be enabled?

[Fujii Hironori]

Created attachment 307545 [details]
Screenshot of AppleWin port MiniBrowser

[Joseph Pecoraro]

Nothing that I know of should cause these kinds of errors.

Maybe something with the JavaScript Intl APIs? First thing to check would be if there are any exceptions in the inspector page itself.

[Fujii Hironori]

Created attachment 307584 [details]
error messages

Thank you, Joseph.
Here are the tow messages output in the secondary Web Inspector:

> Assertion Failed: Attempted to remove a CSSStyleSheet that was not tracked
> Error during DOMAgent operation: No node with given path found

[Fujii Hironori]

Created attachment 307585 [details]
error messages 2

I tested several times. But, I see only the first error message, but the second one.

[Fujii Hironori]

Created attachment 307587 [details]
error messages 3

I can get different error message with different steps.

Steps:

1) Open MiniBrowser
2) Open the first Web Inspector
3) Open the second Web Inspector
4) Open Console tab in the second Web Inspector
5) Open Timelines tab in the first Web Inspector
6) Push the recording button in the first Web Inspector
7) Open google.com in MiniBrowser

[Joseph Pecoraro]

> > Assertion Failed: Attempted to remove a CSSStyleSheet that was not tracked
> > Error during DOMAgent operation: No node with given path found

Okay, these are benign warnings/errors. Unrelated to any serious issue.

[Fujii Hironori]

I found a workaround.
Executing a following expression in the Console tab of the second Web Inspector, Timelines would work fine.

> WebInspector.visible = true

[Fujii Hironori]

WebInspectorUI::setIsVisible is dispatching "setIsVisible" in WebKit2.
I'm guessing a similar method is required in WebKit1 of Windows port.

[Joseph Pecoraro]

Ahh yes!

I'm still very disappointed with that addition to web inspector. It has cost me many hours of debugging to find the same thing in the past. I don't know why such a confusing addition was added.

[Fujii Hironori]

I have two questions.

Timelines tab of remote web inspector of GTK+ port also doesn't work
even though RemoteWebInspectorUI::frontendLoaded in
Source/WebKit2/WebProcess/WebPage/RemoteWebInspectorUI.cpp has a code
to dispatch "setIsVisible". Why?

setIsVisible has been introduced in Bug 157897 for
requestAnimationFrame. Which window does this visibility mean for? The
target window or the inspector window? requestAnimationFrame is used
in the inspector window. Can I use visibility API for ths purpose in
the inspector window?

[Fujii Hironori]

Created attachment 307959 [details]
WIP patch using visibility API

This patch solves the problems of Windows port and remote web inspector of GTK+ port.

[Fujii Hironori]

(In reply to Fujii Hironori from comment #10)
> Timelines tab of remote web inspector of GTK+ port also doesn't work

GTK+ port has switched to ENABLE_REMOTE_INSPECTOR (Bug 166680). It works now.

[Fujii Hironori]

  Bug 157897 – Web Inspector: timelines should not update via requestAnimationFrame unless Web Inspector is visible

Bug 157897 doesn't seem to be solved in a certain condition.
I tested with GTK+ port.

1) Start MiniBrowser
2) Inspect Element
3) Push "Detach into separate window" button
4) Close the inspector window
5) Navigate a web page in the main window
6) Wait for finishing load
7) Reopen the minimized inspector window

Timeline current time marker is starting from 0s.

[Fujii Hironori]

> 4) Close the inspector window

s/Close/Minimize/

[Joseph Pecoraro]

Is this still the case? Can we resolve this?

[Fujii Hironori]

This issue (comment 0) is still valid.

And, Safari Technology Preview 91 also has comment 13 issue.

1. Start Safari
2. Open a web page
3. Inspect Element to open Web Inspector
4. Push "Detach into separate window" button
5. Minimize the inspector window
6. Navigate a web page in the main window
7. Wait for finishing load
8. Reopen the minimized inspector window

Timeline current time marker is starting from 0s.

[Joseph Pecoraro]

(In reply to Fujii Hironori from comment #16)
> This issue (comment 0) is still valid.

Okay! Would you like to provide an updated patch?


> And, Safari Technology Preview 91 also has comment 13 issue.
> 
> 1. Start Safari
> 2. Open a web page
> 3. Inspect Element to open Web Inspector
> 4. Push "Detach into separate window" button
> 5. Minimize the inspector window
> 6. Navigate a web page in the main window
> 7. Wait for finishing load
> 8. Reopen the minimized inspector window
> 
> Timeline current time marker is starting from 0s.

Yes, I've seen this, would be nice to address.

[Fujii Hironori]

This issue is not only for Windows WebKit1, but also Mac port WebKit1
because Bug 157897 changes only WebKit2.
Timelines doesn't work even in Mac WebKit1.

Joseph, would you fix Mac WK1 issue? It will let me know how to fix the Windows WK1 issue.

[Fujii Hironori]

Windows WK1 was removed.