Bug 170898

Summary:

[selectors4] Import W3C Test Suite

Product:

WebKit

Reporter:

Manuel Rego Casasnovas <rego>

Component:

Tools / Tests

Assignee:

Manuel Rego Casasnovas <rego>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, commit-queue, lforschler, rniwa, ryanhaddad, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

170899, 170900, 170935

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews113 for mac-elcapitan	none
Patch for landing	none

Manuel Rego Casasnovas

Reported 2017-04-17 01:26:33 PDT

It'd be nice to import this test suite as it spots an issue on current :focus-within implementation. The suite is at WPT repo: https://github.com/w3c/web-platform-tests/tree/master/css/selectors4

Attachments
Patch (69.45 KB, patch) 2017-04-17 01:43 PDT, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (887.08 KB, application/zip) 2017-04-17 02:57 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.65 MB, application/zip) 2017-04-17 03:06 PDT, Build Bot	no flags	Details
Patch for landing (70.65 KB, patch) 2017-04-18 00:55 PDT, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Manuel Rego Casasnovas

Comment 1 2017-04-17 01:43:33 PDT

Created attachment 307262 [details] Patch

Build Bot

Comment 2 2017-04-17 02:57:39 PDT

Comment on attachment 307262 [details] Patch Attachment 307262 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3550192 New failing tests: imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-003.html imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-001.html imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-004.html imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-005.html imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-002.html

Build Bot

Comment 3 2017-04-17 02:57:40 PDT

Created attachment 307264 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-04-17 03:06:21 PDT

Comment on attachment 307262 [details] Patch Attachment 307262 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3550199 New failing tests: imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-003.html imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-001.html imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-004.html imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-005.html imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-002.html

Build Bot

Comment 5 2017-04-17 03:06:22 PDT

Created attachment 307265 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Manuel Rego Casasnovas

Comment 6 2017-04-17 04:28:05 PDT

It seems the Mac EWSs are failing only in the Shadow DOM tests: (In reply to Build Bot from comment #2) > New failing tests: > imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-003.html > imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-001.html > imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-004.html > imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-005.html > imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-002.html I've tried to reproduce the failure on a macpro, but I couldn't manage to do it. In my case these tests are passing properly, also "mac-wk2" EWS is green. Could someone give me any hint on what's going on here? Thanks!

youenn fablet

Comment 7 2017-04-17 07:18:40 PDT

Not sure why they fail. You can add specific mac-wk1 [Pass Failure] TestExpectations for these I guess.

Manuel Rego Casasnovas

Comment 8 2017-04-18 00:55:49 PDT

Created attachment 307357 [details] Patch for landing

Manuel Rego Casasnovas

Comment 9 2017-04-18 01:01:27 PDT

(In reply to youenn fablet from comment #7) > Not sure why they fail. > You can add specific mac-wk1 [Pass Failure] TestExpectations for these I > guess. It seems a timing issue, I've added more info in bug #170935. I can reproduce the issue now passing "-1" to run-webkit-tests in order to use WK1. Anyway I'll skip them for the first import and then work on getting them unskipped. Thanks for the review.

WebKit Commit Bot

Comment 10 2017-04-18 02:17:23 PDT

Comment on attachment 307357 [details] Patch for landing Clearing flags on attachment: 307357 Committed r215457: <http://trac.webkit.org/changeset/215457>

WebKit Commit Bot

Comment 11 2017-04-18 02:17:25 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 12 2017-04-18 09:33:56 PDT

It looks like the tests should have been marked as 'ImageOnlyFailure' for mac-wk1. I took care of that in https://trac.webkit.org/changeset/215464/webkit.

Manuel Rego Casasnovas

Comment 13 2017-04-18 23:47:12 PDT

(In reply to Ryan Haddad from comment #12) > It looks like the tests should have been marked as 'ImageOnlyFailure' for > mac-wk1. I took care of that in > https://trac.webkit.org/changeset/215464/webkit. Oops, sorry about that. Thanks for fixing it.

Note You need to log in before you can comment on or make changes to this bug.