Summary: | [css-grid] Add support for percentage gaps | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||||||
Component: | Layout and Rendering | Assignee: | Manuel Rego Casasnovas <rego> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bfulgham, buildbot, commit-queue, jfernandez, rniwa, simon.fraser, svillar, zalan | ||||||||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: | https://bugs.chromium.org/p/chromium/issues/detail?id=615248 | ||||||||||||||
Bug Depends on: | 168657 | ||||||||||||||
Bug Blocks: | 60731 | ||||||||||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2017-04-11 22:45:10 PDT
Created attachment 306891 [details]
Patch
Created attachment 306897 [details]
Mini change on ChangeLog
Comment on attachment 306897 [details] Mini change on ChangeLog Attachment 306897 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3522867 New failing tests: webrtc/negotiatedneeded-event-addStream.html Created attachment 306901 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 306897 [details] Mini change on ChangeLog Attachment 306897 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3522979 New failing tests: compositing/absolute-inside-out-of-view-fixed.html Created attachment 306906 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 306897 [details] Mini change on ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=306897&action=review > LayoutTests/fast/css-grid-layout/grid-gutters-as-percentage.html:15 > +.rows50-50 { grid-template-rows: 50px 50px; } We haven't used this kind of notation %d-%d for class names in the past. We normally do things like two100Column or things like that. > LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html:33 > +.gridInvalidColumnGap { grid-column-gap: -webkit-max-content; } Seems unrelated? > LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html:44 > +.gridInvalidImplicitGridGap { grid-gap: -webkit-fit-content; } Ditto. Created attachment 307385 [details]
Patch for landing
Comment on attachment 306897 [details] Mini change on ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=306897&action=review Thanks for the review. >> LayoutTests/fast/css-grid-layout/grid-gutters-as-percentage.html:15 >> +.rows50-50 { grid-template-rows: 50px 50px; } > > We haven't used this kind of notation %d-%d for class names in the past. We normally do things like two100Column or things like that. Ok, changed that. >> LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html:33 >> +.gridInvalidColumnGap { grid-column-gap: -webkit-max-content; } > > Seems unrelated? Indeed, a copy&paste issue. :-) Comment on attachment 307385 [details] Patch for landing Clearing flags on attachment: 307385 Committed r215463: <http://trac.webkit.org/changeset/215463> All reviewed patches have been landed. Closing bug. |