Bug 170503

Summary: Add debug option to run-jsc script
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, saam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Miller
Reported 2017-04-05 06:16:38 PDT
Add debug option to run-jsc script
Attachments
Patch (2.07 KB, patch)
2017-04-05 06:46 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-04-05 06:46:44 PDT
Created attachment 306280 [details] Patch
Yusuke Suzuki
Comment 2 2017-04-05 06:48:38 PDT
Comment on attachment 306280 [details] Patch r=me
WebKit Commit Bot
Comment 3 2017-04-05 07:29:01 PDT
Comment on attachment 306280 [details] Patch Clearing flags on attachment: 306280 Committed r214945: <http://trac.webkit.org/changeset/214945>
WebKit Commit Bot
Comment 4 2017-04-05 07:29:02 PDT
All reviewed patches have been landed. Closing bug.
Saam Barati
Comment 5 2017-04-07 11:44:37 PDT
This broke run-jsc --debug. It now launches a release build under lldb. It seems wrong to change the meaning of --debug. Why not just add a new option to launch under lldb?
Yusuke Suzuki
Comment 6 2017-04-07 11:45:55 PDT
(In reply to Saam Barati from comment #5) > This broke run-jsc --debug. It now launches a release build under lldb. It > seems wrong to change the meaning of --debug. Why not just add a new option > to launch under lldb? https://bugs.webkit.org/show_bug.cgi?id=170587 this will fix the issue.
Note You need to log in before you can comment on or make changes to this bug.