Bug 170587 – [JSC] Change --debug option to --debugger

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Caio Lima]

The new flag to trigger lldb on Tools/Scripts/run-jsc is shadowing the flag --debug to run JSC with Debug build. It should be good change it to --debugger.

[Caio Lima]

Created attachment 306467 [details]
Patch

[Matt Baker]

Comment on attachment 306467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306467&action=review

> Tools/ChangeLog:10
> +        This patch is chaging the new debugger flag for Tools/Scripts/run-jsc

Typo: changing

[Keith Miller]

Comment on attachment 306467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306467&action=review

r=me with comment.

> Tools/Scripts/run-jsc:43
>  my $debug = 0;

nit: I would change this to $debugger.

[Caio Lima]

Created attachment 306485 [details]
Patch for landing

Fixing Keith's comments

[Caio Lima]

Created attachment 306517 [details]
Patch for landing

Fixing Typos as well.

[Saam Barati]

Did you make sure "--debug" no longer launches a release build?

[WebKit Commit Bot]

Comment on attachment 306517 [details]
Patch for landing

Clearing flags on attachment: 306517

Committed r215105: <http://trac.webkit.org/changeset/215105>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Caio Lima]

(In reply to Saam Barati from comment #6)
> Did you make sure "--debug" no longer launches a release build?

Yes. I changed that because I always use "--debug" and "--release".