Bug 170587 - [JSC] Change --debug option to --debugger
Summary: [JSC] Change --debug option to --debugger
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-06 21:47 PDT by Caio Lima
Modified: 2017-04-07 16:26 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.45 KB, patch)
2017-04-06 21:52 PDT, Caio Lima
keith_miller: review+
Details | Formatted Diff | Diff
Patch for landing (1.77 KB, patch)
2017-04-07 04:00 PDT, Caio Lima
no flags Details | Formatted Diff | Diff
Patch for landing (1.77 KB, patch)
2017-04-07 11:06 PDT, Caio Lima
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2017-04-06 21:47:29 PDT
The new flag to trigger lldb on Tools/Scripts/run-jsc is shadowing the flag --debug to run JSC with Debug build. It should be good change it to --debugger.
Comment 1 Caio Lima 2017-04-06 21:52:09 PDT
Created attachment 306467 [details]
Patch
Comment 2 Matt Baker 2017-04-06 22:03:18 PDT
Comment on attachment 306467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306467&action=review

> Tools/ChangeLog:10
> +        This patch is chaging the new debugger flag for Tools/Scripts/run-jsc

Typo: changing
Comment 3 Keith Miller 2017-04-06 22:04:58 PDT
Comment on attachment 306467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306467&action=review

r=me with comment.

> Tools/Scripts/run-jsc:43
>  my $debug = 0;

nit: I would change this to $debugger.
Comment 4 Caio Lima 2017-04-07 04:00:04 PDT
Created attachment 306485 [details]
Patch for landing

Fixing Keith's comments
Comment 5 Caio Lima 2017-04-07 11:06:38 PDT
Created attachment 306517 [details]
Patch for landing

Fixing Typos as well.
Comment 6 Saam Barati 2017-04-07 11:46:38 PDT
Did you make sure "--debug" no longer launches a release build?
Comment 7 WebKit Commit Bot 2017-04-07 11:50:00 PDT
Comment on attachment 306517 [details]
Patch for landing

Clearing flags on attachment: 306517

Committed r215105: <http://trac.webkit.org/changeset/215105>
Comment 8 WebKit Commit Bot 2017-04-07 11:50:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Caio Lima 2017-04-07 16:26:12 PDT
(In reply to Saam Barati from comment #6)
> Did you make sure "--debug" no longer launches a release build?

Yes. I changed that because I always use "--debug" and "--release".