Bug 170503 - Add debug option to run-jsc script
Summary: Add debug option to run-jsc script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-05 06:16 PDT by Keith Miller
Modified: 2017-04-07 11:45 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.07 KB, patch)
2017-04-05 06:46 PDT, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-04-05 06:16:38 PDT
Add debug option to run-jsc script
Comment 1 Keith Miller 2017-04-05 06:46:44 PDT
Created attachment 306280 [details]
Patch
Comment 2 Yusuke Suzuki 2017-04-05 06:48:38 PDT
Comment on attachment 306280 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2017-04-05 07:29:01 PDT
Comment on attachment 306280 [details]
Patch

Clearing flags on attachment: 306280

Committed r214945: <http://trac.webkit.org/changeset/214945>
Comment 4 WebKit Commit Bot 2017-04-05 07:29:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Saam Barati 2017-04-07 11:44:37 PDT
This broke run-jsc --debug. It now launches a release build under lldb. It seems wrong to change the meaning of --debug. Why not just add a new option to launch under lldb?
Comment 6 Yusuke Suzuki 2017-04-07 11:45:55 PDT
(In reply to Saam Barati from comment #5)
> This broke run-jsc --debug. It now launches a release build under lldb. It
> seems wrong to change the meaning of --debug. Why not just add a new option
> to launch under lldb?

https://bugs.webkit.org/show_bug.cgi?id=170587 this will fix the issue.