Bug 170365

Summary:

REGRESSION (r202472): Data Detection overwrites existing links in detected ranges

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, cdumez, commit-queue, enrica, koivisto, ryanhaddad, sam, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=159122

Bug Depends on:

161967

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	commit-queue: commit-queue-

Andy Estes

Reported 2017-03-31 15:07:14 PDT

REGRESSION (r202472): Data Detection overwrites existing links in detected ranges

Attachments
Patch (4.81 KB, patch) 2017-03-31 15:24 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (4.51 KB, patch) 2017-04-05 00:44 PDT, Andy Estes	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2017-03-31 15:11:43 PDT

rdar://problem/29205721

Andy Estes

Comment 2 2017-03-31 15:24:18 PDT

Created attachment 306019 [details] Patch

WebKit Commit Bot

Comment 3 2017-03-31 16:33:27 PDT

Comment on attachment 306019 [details] Patch Clearing flags on attachment: 306019 Committed r214697: <http://trac.webkit.org/changeset/214697>

WebKit Commit Bot

Comment 4 2017-03-31 16:33:29 PDT

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 5 2017-04-01 18:51:16 PDT

WebKit2.DataDetectionReferenceDate has started to time out super frequently after the change. https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/311/steps/run-api-tests/logs/stdio https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20%28Tests%29/builds/354/steps/run-api-tests/logs/stdio

Alexey Proskuryakov

Comment 6 2017-04-01 18:57:22 PDT

Rolled back in r214722.

Andy Estes

Comment 7 2017-04-03 13:51:26 PDT

(In reply to Alexey Proskuryakov from comment #5) > WebKit2.DataDetectionReferenceDate has started to time out super frequently > after the change. > > https://build.webkit.org/builders/ > Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/311/steps/ > run-api-tests/logs/stdio > > https://build.webkit.org/builders/ > Apple%20iOS%2010%20Simulator%20Release%20WK2%20%28Tests%29/builds/354/steps/ > run-api-tests/logs/stdio The test was disabled before this change. I re-enabled it because it passed for me locally, but I guess whatever caused it to be disabled in the first place is still an issue.

Andy Estes

Comment 8 2017-04-04 23:07:18 PDT

I have a fix for the existing test failure here: https://bugs.webkit.org/show_bug.cgi?id=170496

Andy Estes

Comment 9 2017-04-05 00:44:14 PDT

Created attachment 306267 [details] Patch

WebKit Commit Bot

Comment 10 2017-04-05 01:24:51 PDT

Comment on attachment 306267 [details] Patch Clearing flags on attachment: 306267 Committed r214937: <http://trac.webkit.org/changeset/214937>

WebKit Commit Bot

Comment 11 2017-04-05 01:24:53 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 12 2017-04-05 12:43:09 PDT

Reverted r214937 for reason: This change broke an internal build. Committed r214962: <http://trac.webkit.org/changeset/214962>

Ryan Haddad

Comment 13 2017-04-05 13:15:09 PDT

Reverted r214962 for reason: Roll r214937 back in because it wasn't at fault for the build breakage. Committed r214963: <http://trac.webkit.org/changeset/214963>

Andy Estes

Comment 14 2017-04-14 13:45:15 PDT

Reopening now that bug #161967 is resolved again.

WebKit Commit Bot

Comment 15 2017-04-14 13:47:00 PDT

Comment on attachment 306267 [details] Patch Rejecting attachment 306267 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 306267, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: le Source/WebCore/editing/cocoa/DataDetection.mm.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm Hunk #1 FAILED at 60. Hunk #2 succeeded at 90 with fuzz 2 (offset 9 lines). 1 out of 2 hunks FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3535562

Andy Estes

Comment 16 2017-04-14 13:52:48 PDT

Nevermind, Ryan rolled this back in.

Note You need to log in before you can comment on or make changes to this bug.