Bug 169897

Summary: Loosen audio playback restrictions when the volume is 0
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ryanhaddad
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+, mrajca: commit-queue-

Matt Rajca
Reported 2017-03-20 16:25:48 PDT
If a media element is not muted but its volume is 0, we should not impose an audio playback restriction.
Attachments
Patch (9.86 KB, patch)
2017-03-21 16:20 PDT, Matt Rajca 		eric.carlson: review+
mrajca: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Rajca
Comment 1 2017-03-20 16:26:15 PDT
rdar://problem/31149965
Matt Rajca
Comment 2 2017-03-21 16:20:02 PDT
Created attachment 305045 [details] Patch
Matt Rajca
Comment 3 2017-03-21 18:45:17 PDT
r214239
Ryan Haddad
Comment 4 2017-03-22 10:08:07 PDT
This change appears to have caused API test WebKit2.WebsitePoliciesAutoplayEnabled to time out on iOS Simulator: https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/92
Matt Rajca
Comment 5 2017-03-22 10:11:09 PDT
(In reply to Ryan Haddad from comment #4) > This change appears to have caused API test > WebKit2.WebsitePoliciesAutoplayEnabled to time out on iOS Simulator: > https://build.webkit.org/builders/ > Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/92 Oh, interesting. Volume changes to media elements are not supported on iOS. I'll have the test only run on Mac.
Ryan Haddad
Comment 6 2017-03-22 13:35:22 PDT
(In reply to Matt Rajca from comment #5) > (In reply to Ryan Haddad from comment #4) > > This change appears to have caused API test > > WebKit2.WebsitePoliciesAutoplayEnabled to time out on iOS Simulator: > > https://build.webkit.org/builders/ > > Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/92 > > Oh, interesting. Volume changes to media elements are not supported on iOS. > I'll have the test only run on Mac. Can this change be landed soon? It would be great to get the iOS bots back to green again.
Matt Rajca
Comment 7 2017-03-22 13:45:13 PDT
(In reply to Ryan Haddad from comment #6) > (In reply to Matt Rajca from comment #5) > > (In reply to Ryan Haddad from comment #4) > > > This change appears to have caused API test > > > WebKit2.WebsitePoliciesAutoplayEnabled to time out on iOS Simulator: > > > https://build.webkit.org/builders/ > > > Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/92 > > > > Oh, interesting. Volume changes to media elements are not supported on iOS. > > I'll have the test only run on Mac. > > Can this change be landed soon? It would be great to get the iOS bots back > to green again. Working on it now. https://bugs.webkit.org/show_bug.cgi?id=169969
Note You need to log in before you can comment on or make changes to this bug.