Bug 169877

Summary:

Wrap legacy MediaStream API in runtime flag

Product:

WebKit

Reporter:

Jon Lee <jonlee>

Component:

WebKit Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, eric.carlson, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

169871

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

Jon Lee

Reported 2017-03-20 10:38:04 PDT

For consideration: - NavigatorUserMedia.idl - MediaStreamEvent.idl

Attachments
Patch (9.85 KB, patch) 2017-04-10 10:53 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (9.90 KB, patch) 2017-04-10 12:19 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (9.94 KB, patch) 2017-04-10 13:19 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-04-10 10:53:05 PDT

Created attachment 306711 [details] Patch

youenn fablet

Comment 2 2017-04-10 12:19:10 PDT

Created attachment 306728 [details] Patch

WebKit Commit Bot

Comment 3 2017-04-10 13:15:58 PDT

Comment on attachment 306728 [details] Patch Rejecting attachment 306728 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 306728, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://webkit-queues.webkit.org/results/3512974

youenn fablet

Comment 4 2017-04-10 13:19:43 PDT

Created attachment 306732 [details] Patch for landing

WebKit Commit Bot

Comment 5 2017-04-10 14:02:19 PDT

Comment on attachment 306732 [details] Patch for landing Clearing flags on attachment: 306732 Committed r215200: <http://trac.webkit.org/changeset/215200>

WebKit Commit Bot

Comment 6 2017-04-10 14:02:21 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.