Bug 169866

Summary: Add iceCandidatePoolSize to RTCConfiguration
Product: WebKit Reporter: Jon Lee <jonlee>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 169662    
Attachments:
Description Flags
Patch
youennf: review+
Patch for landing
none
Patch for landing none

Jon Lee
Reported 2017-03-19 14:58:19 PDT
Add iceCandidatePoolSize to RTCConfiguration
Attachments
Patch (9.00 KB, patch)
2017-03-19 21:15 PDT, Jon Lee 		youennf: review+
DetailsFormatted DiffDiff
Patch for landing (10.10 KB, patch)
2017-03-20 14:57 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.10 KB, patch)
2017-03-20 19:35 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jon Lee
Comment 1 2017-03-19 21:15:36 PDT
Created attachment 304912 [details] Patch
youenn fablet
Comment 2 2017-03-20 08:36:12 PDT
Comment on attachment 304912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304912&action=review > LayoutTests/webrtc/rtcconfiguration-icecandidatepoolsize.html:12 > +shouldBe('config.iceCandidatePoolSize', '10'); Can we add some bad value cases, like 1000 or 'rr' for iceCandidatrPoolSize. This test also seems like a good work test. Would be cool to make it use testharness.js
Jon Lee
Comment 3 2017-03-20 13:46:56 PDT
I struggled to get the test harness to work at all. It might be something specific to my machine. In any case, I added test cases for undefined, null, -1, 1000, and 'string'.
Jon Lee
Comment 4 2017-03-20 14:57:59 PDT
Created attachment 304952 [details] Patch for landing
Jon Lee
Comment 5 2017-03-20 19:35:36 PDT
Created attachment 304983 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-03-20 20:17:01 PDT
Comment on attachment 304983 [details] Patch for landing Clearing flags on attachment: 304983 Committed r214209: <http://trac.webkit.org/changeset/214209>
Note You need to log in before you can comment on or make changes to this bug.