Bug 169806

Summary: [WebCrypto] Get rid of CryptoKeyData class and all its subclasses
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, cdumez, jiewen_tan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 164938    
Attachments:
Description Flags
Patch
none
Patch cdumez: review+

Description Jiewen Tan 2017-03-16 20:38:19 PDT
Since every CryptoKey class now has its own way to export/import bytes, we can get rid of CryptoKeyData which serves a middle layer of serializing CryptoKeys.
Comment 1 Sam Weinig 2017-08-18 16:45:33 PDT
Created attachment 318558 [details]
Patch
Comment 2 Sam Weinig 2017-08-18 17:03:00 PDT
Created attachment 318561 [details]
Patch
Comment 3 Chris Dumez 2017-08-18 18:31:37 PDT
Comment on attachment 318561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318561&action=review

> Source/WebCore/ChangeLog:17
> +          the implementations except the on on CryptoKeyRSA, which now is

typo: the one on
Comment 4 Sam Weinig 2017-08-18 18:40:56 PDT
Committed r220949: <http://trac.webkit.org/changeset/220949>
Comment 5 Radar WebKit Bug Importer 2017-08-18 18:41:59 PDT
<rdar://problem/33974719>
Comment 6 Radar WebKit Bug Importer 2017-08-18 18:42:01 PDT
<rdar://problem/33974720>