Bug 169663

Summary: Make unit tests return a promise instead of manually calling done
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dewei_zhu, kling, koivisto, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup tests none

Description Ryosuke Niwa 2017-03-14 23:55:01 PDT 
Make the existing unit tests always reutrn a promise instead of manually calling "done" callback.
The promise tests are a lot more stable and less error prone.

See ​https://bugs.webkit.org/show_bug.cgi?id=169648
Comment 1 Ryosuke Niwa 2017-03-14 23:59:06 PDT 
Created attachment 304481 [details]
Cleanup tests
Comment 2 Antti Koivisto 2017-03-15 05:37:31 PDT 
Comment on attachment 304481 [details]
Cleanup tests

Could some of these then() cascades be replaced with await?
Comment 3 Ryosuke Niwa 2017-03-15 10:37:13 PDT 
(In reply to comment #2)
> Comment on attachment 304481 [details]
> Cleanup tests
> 
> Could some of these then() cascades be replaced with await?

Unfortunately not yet since the stable version of node doesn't support it yet.
Comment 4 WebKit Commit Bot 2017-03-15 11:15:50 PDT 
Comment on attachment 304481 [details]
Cleanup tests

Clearing flags on attachment: 304481

Committed r213993: <http://trac.webkit.org/changeset/213993>
Comment 5 WebKit Commit Bot 2017-03-15 11:16:03 PDT 
All reviewed patches have been landed.  Closing bug.