RESOLVED FIXED 169663
Make unit tests return a promise instead of manually calling done 
https://bugs.webkit.org/show_bug.cgi?id=169663
Summary Make unit tests return a promise instead of manually calling done
Ryosuke Niwa
Reported 2017-03-14 23:55:01 PDT
Make the existing unit tests always reutrn a promise instead of manually calling "done" callback. The promise tests are a lot more stable and less error prone. See ​https://bugs.webkit.org/show_bug.cgi?id=169648
Attachments
Cleanup tests (62.15 KB, patch)
2017-03-14 23:59 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-03-14 23:59:06 PDT
Created attachment 304481 [details] Cleanup tests
Antti Koivisto
Comment 2 2017-03-15 05:37:31 PDT
Comment on attachment 304481 [details] Cleanup tests Could some of these then() cascades be replaced with await?
Ryosuke Niwa
Comment 3 2017-03-15 10:37:13 PDT
(In reply to comment #2) > Comment on attachment 304481 [details] > Cleanup tests > > Could some of these then() cascades be replaced with await? Unfortunately not yet since the stable version of node doesn't support it yet.
WebKit Commit Bot
Comment 4 2017-03-15 11:15:50 PDT
Comment on attachment 304481 [details] Cleanup tests Clearing flags on attachment: 304481 Committed r213993: <http://trac.webkit.org/changeset/213993>
WebKit Commit Bot
Comment 5 2017-03-15 11:16:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.