Bug 169648 - Make server tests return a promise instead of manually calling done
Summary: Make server tests return a promise instead of manually calling done
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-14 17:21 PDT by Ryosuke Niwa
Modified: 2017-03-14 20:19 PDT (History)
4 users (show)

See Also:


Attachments
Cleanup the tests (179.34 KB, patch)
2017-03-14 17:26 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Cleaned up some more (186.52 KB, patch)
2017-03-14 19:38 PDT, Ryosuke Niwa
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-03-14 17:21:49 PDT
Right now, some old mocha tests in server-tests are manually calling done.
Return a promise instead since the latest mocha.js supports that,
and manually calling done turned out be error prone.
Comment 1 Ryosuke Niwa 2017-03-14 17:26:37 PDT
Created attachment 304449 [details]
Cleanup the tests
Comment 2 Ryosuke Niwa 2017-03-14 19:38:58 PDT
Created attachment 304465 [details]
Cleaned up some more
Comment 3 Chris Dumez 2017-03-14 19:48:08 PDT
Comment on attachment 304465 [details]
Cleaned up some more

rs=me
Comment 4 Ryosuke Niwa 2017-03-14 20:18:57 PDT
Thanks!
Comment 5 Ryosuke Niwa 2017-03-14 20:19:05 PDT
Committed r213969: <http://trac.webkit.org/changeset/213969>