Bug 169427

Summary: Add delegate support to WebCore
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, esprehn+autocc, keith_miller, kondapallykalyan, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=172253
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Anders Carlsson
Reported 2017-03-09 12:31:12 PST
Add delegate support to WebCore
Attachments
Patch (120.76 KB, patch)
2017-03-09 12:44 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (120.80 KB, patch)
2017-03-09 13:09 PST, Anders Carlsson 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2017-03-09 12:44:15 PST
Created attachment 303956 [details] Patch
WebKit Commit Bot
Comment 2 2017-03-09 12:46:05 PST
Attachment 303956 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/ApplePayError.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2017-03-09 13:09:33 PST
Created attachment 303969 [details] Patch
Geoffrey Garen
Comment 4 2017-03-09 13:12:38 PST
Comment on attachment 303969 [details] Patch r=me
WebKit Commit Bot
Comment 5 2017-03-09 13:13:42 PST
Attachment 303969 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/ApplePayError.cpp:40: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 6 2017-03-09 14:34:58 PST
Committed r213673: <http://trac.webkit.org/changeset/213673>
Alexey Proskuryakov
Comment 7 2017-03-13 10:08:34 PDT
Comment on attachment 303969 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303969&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:38 > +TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000 = $(TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000_$(TARGET_MAC_OS_X_VERSION_MAJOR)); Is this too many zeroes?
Anders Carlsson
Comment 8 2017-03-13 10:13:45 PDT
(In reply to comment #7) > Comment on attachment 303969 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=303969&action=review > > > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:38 > > +TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000 = $(TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000_$(TARGET_MAC_OS_X_VERSION_MAJOR)); > > Is this too many zeroes? Looks like it! It was copied from TARGET_MAC_OS_X_VERSION_LESS_THAN_1012000 :)
Note You need to log in before you can comment on or make changes to this bug.