Summary: | Add delegate support to WebCore | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, cdumez, commit-queue, esprehn+autocc, keith_miller, kondapallykalyan, mark.lam, msaboff, saam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=172253 | ||||||||
Attachments: |
|
Description
Anders Carlsson
2017-03-09 12:31:12 PST
Created attachment 303956 [details]
Patch
Attachment 303956 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/applepay/ApplePayError.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 29 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 303969 [details]
Patch
Comment on attachment 303969 [details]
Patch
r=me
Attachment 303969 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/applepay/ApplePayError.cpp:40: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 29 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r213673: <http://trac.webkit.org/changeset/213673> Comment on attachment 303969 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303969&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:38 > +TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000 = $(TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000_$(TARGET_MAC_OS_X_VERSION_MAJOR)); Is this too many zeroes? (In reply to comment #7) > Comment on attachment 303969 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=303969&action=review > > > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:38 > > +TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000 = $(TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000_$(TARGET_MAC_OS_X_VERSION_MAJOR)); > > Is this too many zeroes? Looks like it! It was copied from TARGET_MAC_OS_X_VERSION_LESS_THAN_1012000 :) |