Bug 169427

Summary: Add delegate support to WebCore
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, esprehn+autocc, keith_miller, kondapallykalyan, mark.lam, msaboff, sbarati
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=172253
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Description Anders Carlsson 2017-03-09 12:31:12 PST
Add delegate support to WebCore
Comment 1 Anders Carlsson 2017-03-09 12:44:15 PST
Created attachment 303956 [details]
Patch
Comment 2 WebKit Commit Bot 2017-03-09 12:46:05 PST
Attachment 303956 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/ApplePayError.cpp:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2017-03-09 13:09:33 PST
Created attachment 303969 [details]
Patch
Comment 4 Geoffrey Garen 2017-03-09 13:12:38 PST
Comment on attachment 303969 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2017-03-09 13:13:42 PST
Attachment 303969 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/ApplePayError.cpp:40:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Anders Carlsson 2017-03-09 14:34:58 PST
Committed r213673: <http://trac.webkit.org/changeset/213673>
Comment 7 Alexey Proskuryakov 2017-03-13 10:08:34 PDT
Comment on attachment 303969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303969&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:38
> +TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000 = $(TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000_$(TARGET_MAC_OS_X_VERSION_MAJOR));

Is this too many zeroes?
Comment 8 Anders Carlsson 2017-03-13 10:13:45 PDT
(In reply to comment #7)
> Comment on attachment 303969 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=303969&action=review
> 
> > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:38
> > +TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000 = $(TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000_$(TARGET_MAC_OS_X_VERSION_MAJOR));
> 
> Is this too many zeroes?

Looks like it! It was copied from TARGET_MAC_OS_X_VERSION_LESS_THAN_1012000 :)