| Summary: | [WebCrypto] Implement SubtleCrypto::DeriveKey method | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||
| Component: | WebCore Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, bugs-noreply, clopez, commit-queue, jiewen_tan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 166746 | ||||||
| Attachments: |
|
||||||
|
Description
Jiewen Tan
2017-03-08 14:30:41 PST
Created attachment 303892 [details]
Patch
Attachment 303892 [details] did not pass style-queue:
ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:227: CryptoAlgorithmAES_GCM::getKeyLength is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:189: CryptoAlgorithmAES_CBC::getKeyLength is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:176: CryptoAlgorithmAES_KW::getKeyLength is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:178: CryptoAlgorithmAES_CFB::getKeyLength is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 4 in 44 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 303892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303892&action=review Looks good. r=me. > Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp:-750 > - ASSERT_NOT_REACHED(); Yay! (In reply to comment #4) > Comment on attachment 303892 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=303892&action=review > > Looks good. r=me. > > > Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp:-750 > > - ASSERT_NOT_REACHED(); > > Yay! Thanks Brent for r+ my patch. Comment on attachment 303892 [details] Patch Clearing flags on attachment: 303892 Committed r213628: <http://trac.webkit.org/changeset/213628> All reviewed patches have been landed. Closing bug. Looks like this broke the 32-bit build of WebKitGTK+ https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/68007 https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/13248 (In reply to comment #8) > Looks like this broke the 32-bit build of WebKitGTK+ > > > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/68007 > https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/13248 Oops. Sorry for it. Glad that you have fixed the problem. (In reply to comment #9) > (In reply to comment #8) > > Looks like this broke the 32-bit build of WebKitGTK+ > > > > > > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/68007 > > https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/13248 > > Oops. Sorry for it. Glad that you have fixed the problem. Have we? I still see the GTK+ 32-bit bots broken https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release Prospective 32-bit GTK build fix landed in r213663: <http://trac.webkit.org/changeset/213663> |